From owner-freebsd-emulation@FreeBSD.ORG Sun Nov 17 21:33:19 2013 Return-Path: Delivered-To: vbox@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0D683AF0 for ; Sun, 17 Nov 2013 21:33:19 +0000 (UTC) Received: from mail-qc0-x22b.google.com (mail-qc0-x22b.google.com [IPv6:2607:f8b0:400d:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C249A25D8 for ; Sun, 17 Nov 2013 21:33:18 +0000 (UTC) Received: by mail-qc0-f171.google.com with SMTP id s13so3401932qcv.30 for ; Sun, 17 Nov 2013 13:33:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=x5wbFccdXS6L/Gai0yM1J/sI+RuMuumbfGzd2loKlQA=; b=bJ5845NxekD2I2MziNh0L7xUTpx7f3muhfkgGk71aF+BGrOv13Zhz8DyNgRyReQNv/ lkwCKg3Ukx+pJqDfaZIgDX7gL1BFymXr96kSI2xYk+WU9Dhl0K7iXrBI5qjeIFZ7lYYn jO6f3ScgWtKIQ3Xt4QlbGS4u6dHXDc1uO5mbs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=x5wbFccdXS6L/Gai0yM1J/sI+RuMuumbfGzd2loKlQA=; b=MDzgzNsCg0koDjJXmeTWJQkBRLLmnxGfEFno4297PhrGJB1oxVYlod/Jr5qxbLdEPl wRXNMUE4AGOaKKsVhwaVHx+LwIneNOaCBiFN2alqYhaNrePsZupzdKu9XZ6v8a8Nf02C +JMgK0o2TjNRVNL/73pKZzA64wGZ7wMM+e/x7JPzvGxHLNFLSagxWYjjJRTHnw5+XQ8c yDnrGXxFsAbRerUvdsyjgf4ImFBBDGsLqrSZMQ+R39UN8CLH4s6JhNpt5NJt16bEDZkb FaL/rkh5Z7rgXCPeosowu8RxaTkkqbatN30CvaDD24hJDX7n8slNM+p043sqh8apFvj+ zQ4A== X-Gm-Message-State: ALoCoQkiLdi5CZOiBN2w5kIcxep5q3/iGfn6tw+ZbOn7YNrXaWgAV2S4sTgnycp2tUj7yb/eLl0t X-Received: by 10.224.80.4 with SMTP id r4mr28893838qak.69.1384723997925; Sun, 17 Nov 2013 13:33:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.96.63.101 with HTTP; Sun, 17 Nov 2013 13:32:46 -0800 (PST) In-Reply-To: <201311131240.rADCe13k071373@freefall.freebsd.org> References: <201311131240.rADCe13k071373@freefall.freebsd.org> From: Eitan Adler Date: Sun, 17 Nov 2013 16:32:46 -0500 Message-ID: Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/virtualbox-ose To: =?UTF-8?Q?Bernhard_Fr=C3=B6hlich?= , bug-followup , Peter Jeremy Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Sun, 17 Nov 2013 21:51:23 +0000 Cc: vbox@freebsd.org X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Nov 2013 21:33:19 -0000 On Wed, Nov 13, 2013 at 7:40 AM, Bernhard Fr=C3=B6hlich = wrote: > The following reply was made to PR ports/182468; it has been noted by GNA= TS. > > From: =3D?ISO-8859-1?Q?Bernhard_Fr=3DF6hlich?=3D > To: bug-followup@FreeBSD.org, peter@rulingia.com > Cc: > Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/v= irtualbox-ose > Date: Wed, 13 Nov 2013 13:31:49 +0100 > > I think the idea and approach is correct but I went for a slighly more > conservative > approach if _GCC_RUNTIME was not set which is true in case base gcc is u= sed=3D This can not possibly be correct as the variable begins with a "_". The initial proposed patch is also incorrect for a similar reason. _GCC_RUNTIME is not valid for use in a ports Makefile. Perhaps it would help if USE_GCC or USES=3Dcompiler exposed a variable indicating the runtime? --=20 Eitan Adler