From owner-svn-src-head@freebsd.org Fri Apr 14 20:19:52 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D9D3BD3A190; Fri, 14 Apr 2017 20:19:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A4CA110D6; Fri, 14 Apr 2017 20:19:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x243.google.com with SMTP id g2so17747784pge.2; Fri, 14 Apr 2017 13:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=jJo3k3OACHc01NZ8uBPNNbceYVwkKcvH3Bt72g26Oe4=; b=bH/dl/JXE8n6VXGD1DyeICnAVUne1XbeiHSKFSmiVtvEjgzPcBqRbuFcLx1pThbYdV F89EZPzj44JMyC/6Jd9cpC5fX4/bODHEXmQDroVUfzqUcew+fdDBMHOWZqtl5hlp6Vaj o+CfHwRwMQxMVgTW3vk/7SOJxL0N6hBQ8VCAaRFSjgHhD17QBuuRxrkgUrqn64BWrEYo C07T2rFlfq+1YIN8EF37vGFRthZ2jisvtYvzgMHpVj6lB23N9u5In39sPggNR4KHwWEg BnCc550/vkh/A8rgefhaaR4QYM8g9d7V5GFQANvvHMf99Zt863k4KBNKQVAfGgrtXt30 Xwlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=jJo3k3OACHc01NZ8uBPNNbceYVwkKcvH3Bt72g26Oe4=; b=ZS7W74EmRvU0TchpOnUsTi4Q4kqMOZAiiMkVZE01TpWupmi1XB0zCm0NHufJBP/Vam GHXK/y3YSRLEXJbV6XVZvPYsvYkv8I2ezk0EI6U3rlB3S36Ns7rxMIZlR85gj/w7uHXO VEpV0m9yk1zqQf3Dd0s+Sq7p6QTVkp6yitNaFXG3YsJg128VGAq3VK7VfWH5cNzHvqwb pclTIpRPXDtcdBO/dSPS3Qe+/Cy8YvsefuXfzeesS8qBoz6vR8CiavTe3X/75LnlWW6j Agnax5ZNrYBvcFZR9sDM136+UyA8zWDcLDRk4UwLJoD0PG1eYujsTDMQqHaLFolc1h7G g4jw== X-Gm-Message-State: AN3rC/4U5TJpw3ZthBbGAlBNSBBZUuFF4vqFyTfkbw3rk3vX1i6ZDiCx Z/RA041IGI1sD7GMdvg= X-Received: by 10.99.238.69 with SMTP id n5mr8791443pgk.6.1492201192141; Fri, 14 Apr 2017 13:19:52 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id g5sm4755745pfe.12.2017.04.14.13.19.50 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Apr 2017 13:19:51 -0700 (PDT) Subject: Re: svn commit: r316938 - head/sbin/savecore Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_F6044C16-A008-41A2-B2C9-8CDBA517C385"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <20170414201431.GF20974@zxy.spb.ru> Date: Fri, 14 Apr 2017 13:19:49 -0700 Cc: Alan Somers , Ngie Cooper , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Message-Id: References: <201704141941.v3EJfmCW003347@repo.freebsd.org> <20170414201431.GF20974@zxy.spb.ru> To: Slawa Olhovchenkov X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 20:19:53 -0000 --Apple-Mail=_F6044C16-A008-41A2-B2C9-8CDBA517C385 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 14, 2017, at 13:14, Slawa Olhovchenkov wrote: >=20 > On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: >=20 >> On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper = wrote: >>> Author: ngie >>> Date: Fri Apr 14 19:41:48 2017 >>> New Revision: 316938 >>> URL: https://svnweb.freebsd.org/changeset/base/316938 >>>=20 >>> Log: >>> savecore: fix space calculation with respect to `minfree` in = check_space(..) >>>=20 >>> - Use strtoll(3) instead of atoi(3), because atoi(3) limits the >>> representable data to INT_MAX. Check the values received from >>> strtoll(3), trimming trailing whitespace off the end to maintain >>> POLA. >>> - Use `KiB` instead of `kB` when describing free space, total = space, >>> etc. I am now fully aware of `KiB` being the IEC standard for = 1024 >>> bytes and `kB` being the IEC standard for 1000 bytes. >>> - Store available number of KiB in `available` so it can be more >>> easily queried and compared to ensure that there are enough KiB = to >>> store the dump image on disk. >>> - Print out the reserved space on disk, per `minfree`, so end-users >>> can troubleshoot why check_space(..) is reporting that there = isn't >>> enough free space. >>>=20 >>> MFC after: 7 weeks >>> Reviewed by: Anton Rang (earlier diff), cem = (earlier diff) >>> Tested with: positive/negative cases (see review); make tinderbox >>> Sponsored by: Dell EMC Isilon >>> Differential Revision: D10379 >>=20 >> The free space calculation is still uselessly conservative, because = it >> doesn't account for the fact that core dumps will always be either >> spare or compressed. The result is that savecore will frequently >> refuse to save corefiles even when there's plenty of space. I >> proposed removing the space check altogether in >> https://reviews.freebsd.org/D2587. However, I agreed to wait until >> after the compressed core dump feature was merged, because then = mostly >> accurate space checks will be possible. AFAIK the compressed core >> dump feature still hasn't been finished. >=20 > Is posible (in the future) to use multiple swaps (on multiple disks) > for save core dumps? Multiple swap devices is already handled by savecore(8), if one uses = fstab(5) or dumpon(8). Otherwise, you must invoke savecore(8) on = individual devices. As far as saving to multiple disks is concerned, I would hope that one = is using a redundancy capable filesystem (zfs) or RAID-like technology = (gmirror, graid, LSI Fusion=E2=80=99s RAID product line) to stripe = and/or mirror the data across multiple disks. Thanks! -Ngie --Apple-Mail=_F6044C16-A008-41A2-B2C9-8CDBA517C385 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY8S7mAAoJEPWDqSZpMIYVD0YP/1KlgFSYpCIlRRlB0/oCMf60 CNmZheuJosq0Hg4ddFIUY3qtkeCGlflCBGT87TtkjUO9JjchT9qThHoxrK6WM+nS URNkAWephN9ZR2XuwkNAtXwOYMBHXvVARYD31YCpCcoCvTIKaVcW4YGfEbNgQOAR k2u64ca8VZEso6BL8CDjR9OWnn61cMKezdi8tnwkgfVbvs2pZo9DpyWpQm0syW8B IjwPe68d7MA74tgggSdAUBnso8GUjJU3QLXYw8vu11x+o9G4OHwQ0d9kO9l7AF3e ACcDF+1pRi4x9qNWpirPeRl2u+BHCbvAExK5OPFemuBFM/tFRgy4hNGTVRPfKmPM w0+zK3PpBJVjh5PS+LdKCRjE5vQvnQF88k2tJmoIlq5a7xCGpoCCLLDrUpv3U3gt vaworVe6X+4WVvOtxdWy77hPKW8LoprrxY7HADBl6SK/713wgX0UqtpOywffkc59 G55JqxKwi/5WyAFRixpFgzN1GXykVUKaROXJhJFHmOK9ET0Evxc4qJsQ3TLW+VGn 7ELzrfd+WjNAoaCtCtufWDhopZO+gzy3JzuzISpVyXlXF0MQjg89ByXqlihi6obK +jmj0mbvrKKEnX9ZQNVEEoHmsVdD0oxa0Ujh0BYH334VyfU3gWV23ogmmZDvI3JI NLtwHCAagYRtm9jSSWzw =nYn+ -----END PGP SIGNATURE----- --Apple-Mail=_F6044C16-A008-41A2-B2C9-8CDBA517C385--