From owner-svn-src-head@FreeBSD.ORG  Tue Nov  4 20:25:02 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 264A3326;
 Tue,  4 Nov 2014 20:25:02 +0000 (UTC)
Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 994249FA;
 Tue,  4 Nov 2014 20:25:01 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by woozle.rinet.ru (8.14.5/8.14.5) with ESMTP id sA4KOxRw016384;
 Wed, 5 Nov 2014 00:24:59 +0400 (MSK) (envelope-from marck@rinet.ru)
Date: Tue, 4 Nov 2014 23:24:59 +0300 (MSK)
From: Dmitry Morozovsky <marck@rinet.ru>
To: Jung-uk Kim <jkim@freebsd.org>
Subject: Re: svn commit: r274095 - head/release
In-Reply-To: <5459340D.2030605@FreeBSD.org>
Message-ID: <alpine.BSF.2.00.1411042320490.47840@woozle.rinet.ru>
References: <201411041724.sA4HOEGD098532@svn.freebsd.org>
 <alpine.BSF.2.00.1411042244180.47840@woozle.rinet.ru>
 <5459340D.2030605@FreeBSD.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
X-NCC-RegID: ru.rinet
X-OpenPGP-Key-ID: 6B691B03
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (woozle.rinet.ru [0.0.0.0]); Wed, 05 Nov 2014 00:24:59 +0400 (MSK)
Cc: svn-src-head@freebsd.org, Glen Barber <gjb@freebsd.org>,
 svn-src-all@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2014 20:25:02 -0000

On Tue, 4 Nov 2014, Jung-uk Kim wrote:

> >> Log: Fix VOLUME_LABEL when BRANCH contains non-alpha characters,
> >> in particular '-' and '.'.
> >
> > [snip]
> >
> > By the way, what are original reasons to not allow '-' and '_' in
> > volume names?
> >
> > It looks a bit inconsistent with other file systems volume
> > labels...
> 
> AFAIK, it is an ISO9660 limitation, i.e., it must be "d-characters".
> 
> http://wiki.osdev.org/ISO_9660#String_format
> http://wiki.osdev.org/ISO_9660#The_Primary_Volume_Descriptor
> 
> In fact, makefs(8) enforces this rule.

Ah, so iso9660 has stricter rules than, say, xFAT/NTFS and even UFS...

Maybe then we could distinguish file system type given to makefs(8) and apply 
different check/sed rules depending on it?

I mean: it looks a bit unexpected (if not uncomfortable) to have label set up 
by outer OS accepted by geom_label (and thus created in /dev tree) but unable 
to duplicate it via makefs(8) and similar mechanisms...

-- 
Sincerely,
D.Marck                                     [DM5020, MCK-RIPE, DM3-RIPN]
[ FreeBSD committer:                                 marck@FreeBSD.org ]
------------------------------------------------------------------------
*** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru ***
------------------------------------------------------------------------