From owner-freebsd-bugs@FreeBSD.ORG  Thu Apr 26 04:40:20 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 49EEC16A4E1
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 26 Apr 2007 04:40:20 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id D773A13C45A
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 26 Apr 2007 04:40:19 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l3Q4eJxm096571
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 26 Apr 2007 04:40:19 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l3Q4eJeZ096570;
	Thu, 26 Apr 2007 04:40:19 GMT (envelope-from gnats)
Date: Thu, 26 Apr 2007 04:40:19 GMT
Message-Id: <200704260440.l3Q4eJeZ096570@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Maxim Konovalov <maxim@macomnet.ru>
Cc: 
Subject: Re: bin/112126: [patch] netstat(1) segfaults on unusual ICMP
	statistics
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Maxim Konovalov <maxim@macomnet.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Apr 2007 04:40:20 -0000

The following reply was made to PR bin/112126; it has been noted by GNATS.

From: Maxim Konovalov <maxim@macomnet.ru>
To: Chris <wefa2@gmx.de>
Cc: bug-followup@FreeBSD.org
Subject: Re: bin/112126: [patch] netstat(1) segfaults on unusual ICMP statistics
Date: Thu, 26 Apr 2007 08:38:27 +0400 (MSD)

 On Thu, 26 Apr 2007, 00:00+0200, Chris wrote:
 
 > Hello,
 >
 > postcriptum - I overlooked one detail of Maxim's patch:
 >
 > > +static  const char *icmpnames[ICMP_MAXTYPE + 1] = {
 >
 > with this he actually avoids the crash in case of an
 > out of sync kernel interface (assumed the array gets
 > automatically zeroed at allocation time - does it ? )
 >
 > But this still produces a very funny netstat output
 > with just numbers and no labels. I continue to prefer
 > my suggestion.
 
 I see:
 
         Output histogram:
                 echo reply: 41
                 destination unreachable: 495
 [...]
         Input histogram:
                 echo reply: 12
                 destination unreachable: 1
                 echo: 41
                 #20: 7
                 icmp traceroute: 16
                 mobile registration req: 25
                 #37: 31
 
 What is yours?
 
 -- 
 Maxim Konovalov