From owner-svn-src-all@freebsd.org Wed Jul 12 22:17:18 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E4D2DA64BD; Wed, 12 Jul 2017 22:17:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7A67E79E1A; Wed, 12 Jul 2017 22:17:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 8F88910AF07; Wed, 12 Jul 2017 18:17:11 -0400 (EDT) From: John Baldwin To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r320918 - head/sbin/savecore Date: Wed, 12 Jul 2017 14:23:52 -0700 Message-ID: <1930640.IHpqZ2aWqS@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <201707121829.v6CITPxG012102@repo.freebsd.org> References: <201707121829.v6CITPxG012102@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Wed, 12 Jul 2017 18:17:11 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2017 22:17:18 -0000 On Wednesday, July 12, 2017 06:29:25 PM Mark Johnston wrote: > Author: markj > Date: Wed Jul 12 18:29:25 2017 > New Revision: 320918 > URL: https://svnweb.freebsd.org/changeset/base/320918 > > Log: > Add a newline after the version string. > > MFC after: 3 days I think the version string normally has a trailing \n emedded in it? Also, have you verified that crashinfo is still able to match the Version String from the generated info.X file? I think it might as it stops printing lines once it matches the second line of the version, so I think (just reading the awk) that it will not include the extra newline in the 'ivers' compared against 'version' from gdb. -- John Baldwin