From owner-dev-commits-src-all@freebsd.org Wed Mar 10 18:36:39 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AFDE657352E for ; Wed, 10 Mar 2021 18:36:39 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DwglW4Q4Hz4SV6 for ; Wed, 10 Mar 2021 18:36:39 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f49.google.com with SMTP id 7so24488871wrz.0 for ; Wed, 10 Mar 2021 10:36:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=SYPW1/rwuoBm47vUZW2vETjGKNJorbaI7+nCpaKvVVU=; b=PHwnZ/6Py1PPEO1dgl7e0IwzlKqo6jBuCtlAq5GKwmT1lULu6cm2AdbmGmToYh6n6n yLJJX5H2z1NtWqJMP/mbutVPHcXOQa9pJn2J8MBiDLVeJxK/yb//iYhi2OcObge0bblQ APoR3xv0Nm4y9584cxoluwjuqPqIJrjIvsUjRP8CEazq8QI0xMB72PqCrNCI2ICVpd/9 iyiEeCoklSmSbzLTsp8zGoKSlSqbtP8hezBnqpmQd/2Yjj9nrTqqWWkIr3yTk1yLhOFn p01TTau4ZHlsJ+nKl/lrKXfLKS9mmTZvzPNxW2ngBZ0SfY5R6hH6JIcxt/Qm5ETvXSi9 X9QA== X-Gm-Message-State: AOAM53012ls+1SB0XJ9N6fH5I01QoSBOTexCDLL1lfgN5c7xy96+++yc xSwRs0uU4zI+FHWpocp/iHvISA== X-Google-Smtp-Source: ABdhPJzGX01xAWHSPw7VtSJ8Pu9fCriMcwm538KbebTDykI8oKO1zN2ylCNYXgVwF5/U4UlZbpq9hQ== X-Received: by 2002:a5d:6404:: with SMTP id z4mr3449089wru.109.1615401397929; Wed, 10 Mar 2021 10:36:37 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id u63sm305967wmg.24.2021.03.10.10.36.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Mar 2021 10:36:36 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: c328f64d8107 - main - arm64: Fix COMPAT_FREEBSD32. From: Jessica Clarke In-Reply-To: <202103101807.12AI7IVW089870@gitrepo.freebsd.org> Date: Wed, 10 Mar 2021 18:36:35 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <28B50FA6-65E4-4A5A-8339-8A4A8720974B@freebsd.org> References: <202103101807.12AI7IVW089870@gitrepo.freebsd.org> To: Olivier Houchard , John Baldwin X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4DwglW4Q4Hz4SV6 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2021 18:36:39 -0000 On 10 Mar 2021, at 18:07, Olivier Houchard wrote: >=20 > The branch main has been updated by cognet: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dc328f64d81079bad5064c8a387883df5= 0ab5aaed >=20 > commit c328f64d81079bad5064c8a387883df50ab5aaed > Author: Olivier Houchard > AuthorDate: 2021-03-10 18:01:41 +0000 > Commit: Olivier Houchard > CommitDate: 2021-03-10 18:06:42 +0000 >=20 > arm64: Fix COMPAT_FREEBSD32. >=20 > The ENTRY() macro was modified by commit > 28d945204ea1014d7de6906af8470ed8b3311335 to add an optional NOP = instruction > at the beginning of the function. It is of course an arm64 = instruction, so > unsuitable for the 32bits sigcode. So just use EENTRY() instead for > aarch32_sigcode. This should fix receiving signals when running = 32bits > binaries on FreeBSD/arm64. Hmm, that's a good point, does the extra nop for the AArch64 sigcode cause issues for gdb detecting it? Perhaps we should upstream CheriBSD's SIGCODE macros?.. Jess Jess