From owner-p4-projects@FreeBSD.ORG Fri Jan 4 18:44:44 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 7A57516A474; Fri, 4 Jan 2008 18:44:44 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3FE5116A417 for ; Fri, 4 Jan 2008 18:44:44 +0000 (UTC) (envelope-from gonzo@freebsd.org) Received: from bugor.portaone.com (bugor.portaone.com [65.61.203.147]) by mx1.freebsd.org (Postfix) with ESMTP id 2741813C46A for ; Fri, 4 Jan 2008 18:44:44 +0000 (UTC) (envelope-from gonzo@freebsd.org) Received: from mail.pbxpress.com ([65.61.203.142] helo=leaf.pbxpress.com) by bugor.portaone.com (8.11.3/8.11.3) with ESMTP (TLSv1:AES256-SHA:256)id 1JArX9-0004DF-VM; Fri, 04 Jan 2008 10:44:43 -0800 Received: from jeeves.bluezbox.com (k3-gw.portaone.com [193.28.87.193]) (authenticated bits=0) by leaf.pbxpress.com (8.13.3/8.13.3) with ESMTP id m04Ij0wC083393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Jan 2008 10:45:02 -0800 (PST) (envelope-from gonzo@freebsd.org) Message-ID: <477E7E9A.9060400@freebsd.org> Date: Fri, 04 Jan 2008 20:44:42 +0200 From: Oleksandr Tymoshenko User-Agent: Thunderbird 2.0.0.6 (X11/20070907) MIME-Version: 1.0 To: "M. Warner Losh" References: <200801041711.m04HBGPG029002@repoman.freebsd.org> <20080104.111926.-108774279.imp@bsdimp.com> In-Reply-To: <20080104.111926.-108774279.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, recieved from trusted server Cc: perforce@freebsd.org Subject: Re: PERFORCE change 132497 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2008 18:44:44 -0000 M. Warner Losh wrote: > In message: <200801041711.m04HBGPG029002@repoman.freebsd.org> > Oleksandr Tymoshenko writes: > : http://perforce.freebsd.org/chv.cgi?CH=132497 > : > : Change 132497 by gonzo@gonzo_jeeves on 2008/01/04 17:11:07 > : > : o I believe MK_ZFS is more appropriate variable to be checked > : in this case. > > I thought this was more a case of 'exclude all CDDL code' rather than > being tied to ZFS. This particular case is strictly ZFS-related. Also, WITHOUT_CDDL implies WITHOUT_ZFS in bsd.own.mk, so it's just more precise check. -- gonzo