From owner-freebsd-current  Sun Sep  6 20:20:02 1998
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id UAA04714
          for freebsd-current-outgoing; Sun, 6 Sep 1998 20:20:02 -0700 (PDT)
          (envelope-from owner-freebsd-current@FreeBSD.ORG)
Received: from rf900.physics.usyd.edu.au (rf900.physics.usyd.edu.au [129.78.129.109])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA04663
          for <current@FreeBSD.ORG>; Sun, 6 Sep 1998 20:19:56 -0700 (PDT)
          (envelope-from dawes@rf900.physics.usyd.edu.au)
Received: (from dawes@localhost) by rf900.physics.usyd.edu.au (8.8.5/8.8.2) id NAA14636; Mon, 7 Sep 1998 13:19:50 +1000 (EST)
Message-ID: <19980907131950.D14380@rf900.physics.usyd.edu.au>
Date: Mon, 7 Sep 1998 13:19:50 +1000
From: David Dawes <dawes@rf900.physics.usyd.edu.au>
To: current@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/kern subr_bus.c uipc_socket2.c
Mail-Followup-To: current@FreeBSD.ORG
References: <199809061801.LAA00223@austin.polstra.com> <199809070103.SAA13578@bubba.whistle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.91.1i
In-Reply-To: <199809070103.SAA13578@bubba.whistle.com>; from Archie Cobbs on Sun, Sep 06, 1998 at 06:03:30PM -0700
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Sun, Sep 06, 1998 at 06:03:30PM -0700, Archie Cobbs wrote:
>John Polstra writes:
>> > BTW: How far are we from using -Wall -Werror for the whole source
>> > tree, including kernel ?
>> 
>> We should never add -Werror to the standard flags.  If somebody
>> compiles without "-O", the compiler generates spurious warnings.
>> These kill the build if -Werror is present.
>
>That's arguable. Anyone who's capable of removing the -O from some
>included makefile is capable of removing -Werror from some included
>makefile.
>
>In practice, however, -Werror may not be workable... it would be an
>interesting experiment anyway.
>
>> Of course, we should still strive for the goal of "-O -Wall -Werror"
>> working.
>
>Not to mention -Wstrict-prototypes, -Wmissing-prototypes,
>-Wmissing-declarations, -Wnested-externs, ... what else??

In the current XFree86 devel source, we use those plus -Wpointer-arith
and -Wredundant-decls.  I consider the former important.  The latter one
generates a lot of noise from the system headers on many OSs (although
FreeBSD is fairly clean in that regard).  We don't use -Werror, and
we'll probably relax the warnings before this development code is released.

David

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message