From owner-freebsd-bugs@freebsd.org Wed Jul 1 07:05:48 2015 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E5D4C993244 for ; Wed, 1 Jul 2015 07:05:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CA7B81AF6 for ; Wed, 1 Jul 2015 07:05:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t6175lOI055463 for ; Wed, 1 Jul 2015 07:05:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 201240] Ping does not work after MAC change on ixl (Intel Fortville NIC) link Date: Wed, 01 Jul 2015 07:05:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: pushkar.kothavade@msystechnologies.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2015 07:05:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201240 Bug ID: 201240 Summary: Ping does not work after MAC change on ixl (Intel Fortville NIC) link Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: pushkar.kothavade@msystechnologies.com Issue I am evaluating functionality of Intel Fortville NIC on FreeBSD platform. Change in MAC address on a ixl (Intel Fortville NIC) link does not reflect on NIC. Ping stops working after change in MAC address. Ping works, if PROMISC mode is set. Steps to reproduce the problem # ifconfig ixl1 ixl1: flags=8843 metric 0 mtu 9000 options=6407bb ether 68:05:ca:35:97:29 nd6 options=29 media: Ethernet autoselect (10Gbase-Twinax ) status: active # ping XYZ Ping Works # ifconfig ixl1 ether 58:04:89:12:34:56 Assign new MAC to the link. # ping XYZ Ping does _NOT_ Work Bug Analysis While working on this issue, I found bug in the code. Refer 'ixl_init_locked(struct ixl_pf *pf) function' present in 'dev/ixl/if_ixl.c' file. 1080 /* Get the latest mac address... User might use a LAA */ 1081 bcopy(IF_LLADDR(vsi->ifp), tmpaddr, 1082 I40E_ETH_LENGTH_OF_ADDRESS); 1083 if (!cmp_etheraddr(hw->mac.addr, tmpaddr) && 1084 i40e_validate_mac_addr(tmpaddr)) { 1085 bcopy(tmpaddr, hw->mac.addr, 1086 I40E_ETH_LENGTH_OF_ADDRESS); 1087 ret = i40e_aq_mac_address_write(hw, 1088 I40E_AQC_WRITE_TYPE_LAA_ONLY, 1089 hw->mac.addr, NULL); 1090 if (ret) { 1091 device_printf(dev, "LLA address" 1092 "change failed!!\n"); 1093 return; 1094 } 1095 } Refer lines 1083 & 1084 - 'i40e_validate_mac_addr(tmpaddr)' function returns 0 on success. Therefore 'i40e_aq_mac_address_write()' function is not getting called. Bug Fix is as Follows - if (!cmp_etheraddr(hw->mac.addr, tmpaddr) && i40e_validate_mac_addr(tmpaddr) == I40E_SUCCESS) After this fix, 'i40e_aq_mac_address_write()' function is getting called. Conclusion This 'bug fix' could not resolve the Ping issue. -- You are receiving this mail because: You are the assignee for the bug.