Date: Thu, 08 Sep 2011 23:43:43 +0200 From: Miroslav Lachman <000.fbsd@quip.cz> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: "ports@FreeBSD.org" <ports@FreeBSD.org>, Sahil Tandon <sahil@tandon.net>, Sahil Tandon <sahil@FreeBSD.org> Subject: Re: USERS/GROUPS in bsd.port.mk [was: FreeBSD Port: postfix-2.8.4, 1] Message-ID: <4E69370F.3010102@quip.cz> In-Reply-To: <20110908212658.GJ31003@azathoth.lan> References: <4E368625.7010805@quip.cz> <4E370ADA.9060902@FreeBSD.org> <4E371284.5010806@quip.cz> <4E371B3B.7070806@FreeBSD.org> <4E3722DE.6050206@gmx.de> <20110802010139.GA981@magic.hamla.org> <4E37F71D.7070502@quip.cz> <4E68A89B.6040701@quip.cz> <239A3DFB-E98E-4481-A74E-3B0C6891935C@tandon.net> <20110908212658.GJ31003@azathoth.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
Baptiste Daroussin wrote: > On Thu, Sep 08, 2011 at 01:19:26PM -0400, Sahil Tandon wrote: >> On Sep 8, 2011, at 7:35 AM, Miroslav Lachman<000.fbsd@quip.cz> wrote: >> >>> Miroslav Lachman wrote: >>>> Sahil Tandon wrote: >>>>> On Tue, 2011-08-02 at 00:04:14 +0200, olli hauer wrote: >>>>> >>>>>> No, you don't hit the limitation. It seems you really found a bug in >>>>>> the Framework! >>>>>> >>>>>> From the Framework code in bsd.port.mk existing groups should honored. >>>>> >>>>> Along those lines, what about using groupmod instead of usermod? >>>>> Perhaps due to my ignorance, it seems more straightforward and does not >>>>> require much sed-fu; I've attached a (probably incomplete) patch to >>>>> illustrate my thinking. I understand what I am suggesting could >>>>> introduce other problems, so please do not construe it as an as-is >>>>> suggestion, but rather something to stoke discussion. >>>> >>>> I tested your patch and it works for me. >>>> >>>> # pkg_version -vIL = | grep postfix >>>> postfix-2.7.2,1< needs updating (index has 2.8.4,1) >>>> >>>> # id postfix >>>> uid=125(postfix) gid=125(postfix) >>>> groups=125(postfix),6(mail),3125(maildirs) >>>> >>>> # patch< ~/bsd.port.mk.diff >>>> >>>> # portmaster postfix-2.7.2,1 >>>> >>>> ===>>> The following actions were performed: >>>> Upgrade of mysql-client-5.1.53 to mysql-client-5.1.58 >>>> Upgrade of libtool-2.2.10 to libtool-2.4 >>>> Upgrade of cyrus-sasl-2.1.23_1 to cyrus-sasl-2.1.23_3 >>>> Upgrade of postfix-2.7.2,1 to postfix-2.8.4,1 >>>> >>>> # id postfix >>>> uid=125(postfix) gid=125(postfix) >>>> groups=125(postfix),6(mail),3125(maildirs) >>>> >>>> It was tested on really old testing system... >>>> >>>> Thank you for your time and working solution. >>> >>> Will the fix be committed to the ports tree? I upgraded Postfix on another machines yesterday and get the same error as reported month ago - upgrade removed postfix from manualy created group. >>> >>> Should I send PR for this? >> >> I am very sorry to hear that. I already filed a PR after you sent your report to this mailing list, and followed up with portmgr@ earlier this week. I believe they are doing an -exp run before committing the change. I will ping them again if there is no progress in the next few days. Sorry again for the inconvenience. Ah, right, I forgot that you already filed a PR for this... > > The exp-run is running right now, some news about this in the next couple of > days Thank you guys, I really appreciate your work on FreeBSD project! Miroslav Lachman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E69370F.3010102>