From owner-freebsd-hackers  Tue Jan 21 19:58: 6 2003
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1B58A37B401
	for <hackers@FreeBSD.ORG>; Tue, 21 Jan 2003 19:58:05 -0800 (PST)
Received: from citusc.usc.edu (citusc.usc.edu [128.125.38.123])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A07F243E4A
	for <hackers@FreeBSD.ORG>; Tue, 21 Jan 2003 19:58:04 -0800 (PST)
	(envelope-from kris@citusc.usc.edu)
Received: (from kris@localhost)
	by citusc.usc.edu (8.11.6/8.11.2) id h0M3w3O32733;
	Tue, 21 Jan 2003 19:58:03 -0800
Date: Tue, 21 Jan 2003 19:58:03 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Matthew Dillon <dillon@apollo.backplane.com>
Cc: hackers@FreeBSD.ORG, Hiten Pandya <hiten@unixdaemons.com>
Subject: Re: patch to remove random #define MIN/MAX implementations from around the kernel
Message-ID: <20030121195803.A32701@citusc.usc.edu>
References: <200301220325.h0M3PiNt099890@apollo.backplane.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-md5;
	protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK"
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <200301220325.h0M3PiNt099890@apollo.backplane.com>; from dillon@apollo.backplane.com on Tue, Jan 21, 2003 at 07:25:44PM -0800
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG


--CE+1k2dSO48ffgeK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jan 21, 2003 at 07:25:44PM -0800, Matthew Dillon wrote:
>     This patch is going to go in on the weekend unless someone has any
>     worthwhile nits about it.  It was submitted by Hiten Pandya.

> Index: contrib/dev/oltr/if_oltr.c

> Index: contrib/ipfilter/netinet/ip_proxy.c

> Index: netinet6/nd6.c

You shouldn't modify vendor code for minor purposes.

Kris
--CE+1k2dSO48ffgeK
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE+LhbLWry0BWjoQKURAoriAJ0Xqs+wi710Oy40di48l3pirz2twQCg8iOe
+1eXoOnJz1xn0rV1aSyNoLs=
=Khbx
-----END PGP SIGNATURE-----

--CE+1k2dSO48ffgeK--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message