From owner-freebsd-current@FreeBSD.ORG  Sat Jun 30 08:01:32 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 850D416A400;
	Sat, 30 Jun 2007 08:01:32 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from cs1.cs.huji.ac.il (cs1.cs.huji.ac.il [132.65.16.10])
	by mx1.freebsd.org (Postfix) with ESMTP id 3F99213C44B;
	Sat, 30 Jun 2007 08:01:32 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from pampa.cs.huji.ac.il ([132.65.80.32])
	by cs1.cs.huji.ac.il with esmtp
	id 1I4Xta-000805-Rz; Sat, 30 Jun 2007 11:01:30 +0300
X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2
To: "Wojciech A. Koszek" <wkoszek@freebsd.org>
In-reply-to: Your message of Sat, 30 Jun 2007 08:15:17 +0000 .
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sat, 30 Jun 2007 11:01:30 +0300
From: Danny Braniss <danny@cs.huji.ac.il>
Message-ID: <E1I4Xta-000805-Rz@cs1.cs.huji.ac.il>
Cc: freebsd-current@freebsd.org
Subject: Re: INCLUDE_CONFIG_FILE off-by-one problem 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Jun 2007 08:01:32 -0000

> On Sat, Jun 30, 2007 at 09:00:13AM +0300, Danny Braniss wrote:
> > > On Wed, Jun 06, 2007 at 10:18:40AM +0300, Danny Braniss wrote:
> > > > to get the config file from the kernel, one can use config -k, which
> > > > executes elfdump to get the offset and size. The size is actually 1(one)
> > > > byte too big, and so the output of config -k contains a NULL/0/^@ as
> > > > the last byte. I think the problem is in the elf file.
> > > 
> > > Why do you think that the problem lies in the ELF file?
> > the size is wrongly reported.
> 
> Hm. Not sure which notion of size you mean in this context.
> Configuration file is basically pretty standard sysctl, from which it's
> exported.
> 
> > 
> > > 
> > > Can you confirm that following sysctls:
> > > 
> > > 	kern.geom.confxml
> > > 	kern.geom.conftxt
> > > 
> > > don't suffer from the same problem?
> > they are both empty. (and yes, geom_label is loaded).
> 
> They're not related with GEOM_LABEL. I belive you haven't used -b flag
> while trying to see their contents. If you try:
> 
> 	sysctl -b kern.geom.confxml
> 
> or
> 
> 	sysctl -b kern.geom.conftxt
> 
> You'll notice these sysctls also contain NULL byte at the end, and they
> both suffer from being recognized as a binary files, while piped to
> grep(1).
> 
> I'll look into this. If the kernel side of this interface is correct, I'm
> going to simply modify config(8) to skip the last byte of the output.

ok, so here is the output, and it seems bad under 6.2 too.
bsd> sysctl -b kern.geom.confxml | cat -v|tail
      <rank>4</rank>
        <consumer id="0xffffff00ac73fd00">
          <geom ref="0xffffff00ac999900"/>
          <provider ref="0xffffff00ac591500"/>
          <mode>r1w1e1</mode>
        </consumer>
    </geom>
  </class>
</mesh>
^@bsd> 
^
|
+------ the extra null
> 
> Thanks for the report,
thank you!
	danny