From owner-cvs-src-old@FreeBSD.ORG Sun Oct 17 16:43:35 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A831010657C7 for ; Sun, 17 Oct 2010 16:43:35 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7975B8FC0C for ; Sun, 17 Oct 2010 16:43:35 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id o9HGhZ6a092242 for ; Sun, 17 Oct 2010 16:43:35 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id o9HGhZSm092241 for cvs-src-old@freebsd.org; Sun, 17 Oct 2010 16:43:35 GMT (envelope-from pjd@repoman.freebsd.org) Message-Id: <201010171643.o9HGhZSm092241@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to pjd@repoman.freebsd.org using -f From: Pawel Jakub Dawidek Date: Sun, 17 Oct 2010 16:43:20 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_8 Subject: cvs commit: src/sbin/hastd control.c hastd.c hooks.c hooks.h pjdlog.c primary.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2010 16:43:35 -0000 pjd 2010-10-17 16:43:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_8) sbin/hastd control.c hastd.c hooks.c hooks.h pjdlog.c primary.c Log: SVN rev 213984 on 2010-10-17 16:43:20Z by pjd MFC r213183,r213428,r213429,r213430,r213529,r213530,r213531,r213533,r213579, r213580,r213938,r213939,r213981: r213183: Plug memory leak on fork(2) failure. Submitted by: Mikolaj Golub r213428: We can't mask ignored signal, so install dummy signal hander for SIGCHLD before masking it. This fixes bogus reports about hooks running for too long and other problems related to garbage-collecting child processes. Reported by: Mikolaj Golub r213429: hook_check() is now only used to report about long-running hooks, so the argument is redundant, remove it. r213430: Decrease report interval to 5 seconds, as this also means we will check for signals every 5 seconds and not every 10 seconds as before. r213529: Don't close local component on exit as we can hang waiting on g_waitidle. I'm unable to reproduce the race described in comment anymore and also the comment is incorrect - localfd represents local component from configuration file, eg. /dev/da0 and not HAST provider. Reported by: Mikolaj Golub r213530: Start the guard thread first, so we can handle signals from the very begining. Reported by: Mikolaj Golub r213531: Log error message when we fail to destroy ggate provider. r213533: Clear ggate structures before using them. We don't initialize all the field and there can be some garbage from the stack. r213579: We close the event socketpair early in the mainloop to prevent spaming with error messages, so when we clean up after child process, we have to check if the event socketpair is still there. Submitted by: Mikolaj Golub r213580: We can't zero out ggio request, as we have some fields in there we initialize once during start-up. Reported by: Mikolaj Golub r213938: Clear signal mask before executing a hook. Submitted by: Mikolaj Golub r213939: Use one fprintf() instead of two. r213981: Log correct connection when canceling half-open connection. Submitted by: Mikolaj Golub Revision Changes Path 1.1.2.4 +4 -2 src/sbin/hastd/control.c 1.2.2.7 +15 -3 src/sbin/hastd/hastd.c 1.1.2.4 +5 -11 src/sbin/hastd/hooks.c 1.1.2.4 +1 -1 src/sbin/hastd/hooks.h 1.2.2.5 +1 -2 src/sbin/hastd/pjdlog.c 1.3.2.7 +12 -11 src/sbin/hastd/primary.c