From owner-freebsd-bugs@freebsd.org  Tue Sep  5 18:00:53 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 04C43E15D64
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Tue,  5 Sep 2017 18:00:53 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 50F4A83A4E
 for <freebsd-bugs@FreeBSD.org>; Tue,  5 Sep 2017 18:00:52 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v85I0qVB082274
 for <freebsd-bugs@FreeBSD.org>; Tue, 5 Sep 2017 18:00:52 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 222077] geli(8) writing uninitialized memory out to disk
Date: Tue, 05 Sep 2017 18:00:52 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.1-RELEASE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: max@mxcrypt.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-222077-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Sep 2017 18:00:53 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222077

            Bug ID: 222077
           Summary: geli(8) writing uninitialized memory out to disk
           Product: Base System
           Version: 11.1-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: max@mxcrypt.com

When geli(8) is configured to use authenticated encryption, it has to
interleave data with HMACs. A 4096-byte encrypted sector requires nine 512-=
byte
sectors from the underlying provider, with the last sector having 224 bytes
unused.

I was configuring an encrypted vnode-type memory disk and decided to look at
the metadata that geli writes to the end of the file with hexdump. To my
surprise, I also found other plain-text data in the 224 unused bytes of eve=
ry
9th sector. For example (hex columns omitted):

000ff520  |om>.    <geom id|
000ff530  |=3D"XXXXXXXXXXXXXX|
000ff540  |XXXX">.      <cl|
000ff550  |ass ref=3D"XXXXXXX|
000ff560  |XXXXXXXXXXX"/>. |
000ff570  |     <name>diski|
000ff580  |d/XXXXXXXXXXXXX<|
000ff590  |/name>.      <ra|
000ff5a0  |nk>3</rank>..<co|
000ff5b0  |nsumer id=3D"XXXXX|
000ff5c0  |XXXXXXXXXXXXX">.|
000ff5d0  |.  <geom ref=3D"XX|
000ff5e0  |XXXXXXXXXXXXXXXX|
000ff5f0  |"/>..  <provider|
000ff600  |................|

This is a portion of sysctl kern.geom.confxml (with real data replaced by X=
s)
that made its way into my memory disk file. The script below can be used to
reproduce this problem, though the actual data will obviously vary. It may =
be
necessary to increase the memory disk size for this behavior to become
apparent.

It looks like geli is obtaining some uninitialized memory for the last outp=
ut
sector and not erasing the unused bytes before writing the sector out to di=
sk.
I took a brief look at the code, but couldn't figure out where the memory is
coming from, so I'm not sure of the severity of this bug and whether it may
expose some sensitive data.

Either way, the uninitialized bytes should be either set to zero or replaced
with random data to make them indistinguishable from the rest (though there=
 is
probably no real security benefit from doing so because of the geli metadat=
a at
the end of the device).

Script to create an authenticated memory disk (use `hd gelitest.md` to insp=
ect
contents):

#!/bin/sh
dd if=3D/dev/zero of=3Dgelitest.md bs=3D1M count=3D1 status=3Dnone
md=3D$(mdconfig -f gelitest.md) || exit
echo fakekey | geli init -a HMAC/SHA256 -B none -K - -P -s 4096 $md || exit
echo fakekey | geli attach -k - -p $md || exit
dd if=3D/dev/zero of=3D/dev/$md.eli bs=3D1M status=3Dnone
geli detach /dev/$md.eli
mdconfig -du $md

--=20
You are receiving this mail because:
You are the assignee for the bug.=