Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Apr 2013 19:49:37 +0000 (UTC)
From:      Alan Somers <asomers@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r249951 - head/sbin/devd
Message-ID:  <201304261949.r3QJnbX4022892@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: asomers
Date: Fri Apr 26 19:49:37 2013
New Revision: 249951
URL: http://svnweb.freebsd.org/changeset/base/249951

Log:
  According to devctl(4), clients must read events whole; they may not
  piece them together from multiple reads().  It's as if /dev/devctl is
  a datagram device instead of a stream device.  However, devd's
  internal buffer was too small (1025 bytes) to read an entire
  ereport.fs.zfs.checksum event (variable, up to ~1300 bytes).  This
  commit enlarges the buffer to 8k.
  
  Reviewed by:	imp
  Approved by:	ken (mentor)
  MFC after:	2 weeks

Modified:
  head/sbin/devd/devd.h

Modified: head/sbin/devd/devd.h
==============================================================================
--- head/sbin/devd/devd.h	Fri Apr 26 17:56:35 2013	(r249950)
+++ head/sbin/devd/devd.h	Fri Apr 26 19:49:37 2013	(r249951)
@@ -53,6 +53,6 @@ int  yyparse(void);
 __END_DECLS
 
 #define PATH_DEVCTL	"/dev/devctl"
-#define DEVCTL_MAXBUF	1025
+#define DEVCTL_MAXBUF	8192
 
 #endif /* DEVD_H */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201304261949.r3QJnbX4022892>