From owner-cvs-all Tue Sep 10 20:15:14 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24AE037B400; Tue, 10 Sep 2002 20:15:11 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA33743E6A; Tue, 10 Sep 2002 20:15:10 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.6/8.12.2) with ESMTP id g8B3FAfO016070; Tue, 10 Sep 2002 20:15:10 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.6/8.12.5/Submit) id g8B3FAS9016069; Tue, 10 Sep 2002 20:15:10 -0700 (PDT) Date: Tue, 10 Sep 2002 20:15:10 -0700 From: "David O'Brien" To: Tony Finch Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/uudecode uudecode.c Message-ID: <20020911031509.GA15389@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org Mail-Followup-To: David O'Brien , Tony Finch , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200209102114.g8ALEE6d063516@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200209102114.g8ALEE6d063516@freefall.freebsd.org> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Sep 10, 2002 at 02:14:14PM -0700, Tony Finch wrote: > fanf 2002/09/10 14:14:14 PDT > > Modified files: > usr.bin/uudecode uudecode.c > Log: > Fix style bugs in macros. Geez this is ridiculous, could you *please* batch changes a little bit better than this?? You've committed 10 times to uudecode.c in less than 3 hours. (11 times since Sept 3rd). This is a single file program of only 361 lines (wc -l uudecode.c (this includes comments, blank lines, everything). These could all be made in a single commit: Style: space after return. Remove register keyword. Fix style bugs in macros. P.S. `make buildworld' to test them would also be nice. ;-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message