From owner-svn-src-head@freebsd.org Fri Feb 28 02:02:08 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A965B25654B for ; Fri, 28 Feb 2020 02:02:08 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48TCTW4bfJz4qv6 for ; Fri, 28 Feb 2020 02:02:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf33.google.com with SMTP id by15so629706qvb.11 for ; Thu, 27 Feb 2020 18:02:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gUiczxBpokjl0OovfrbB20BwP9W584TK2wcfUspYBNw=; b=qZUu8ZCYvcX/e4L1za6IbMhwS4RfXHrhTeg9AgBuXVDcbBlVCRx7DeLzl4GSzTDwHO hH/g6goVCL/XCErgRoNL+N/5DGiRP1rGhp+GyhiJCtWzlZwC2iC5ovDWDNg2MWJHYfGZ 3GMyyLpHPXASpoDzuEN9HE9XDTtByQvSgLdSUQAXq3vjp8zoclxEGVm3R449niZtO6FR RZlOjznOuQ9u3+33Er6BUQXAhvOcD12rZIz/U4CmhvRwNLgn8/QnfXOq79+GPwGDM4s/ XbJYHprwxPex7qTK40nSvCntNm1U1Ug6dp3aQY2L2YWU0GHIPQMP+/1JDSpo7TZC9G8D GMlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gUiczxBpokjl0OovfrbB20BwP9W584TK2wcfUspYBNw=; b=BuB6rSgNVzjRwIxabb62j2hR0oZ8RRLNfuD/GF4wA6np+tdfexpZ64/cmwCaug3AbJ UZwSSefahJNdx7ihUVBGsQeB1R/b1g8egG2CWRVrAd0XiTyeKpAPXMQUz4OhncVtRIiR PnXEUL1MIMCCZpN46dFfdUc9P2TOB98VeopFoKxu8HDZZBwg7Dl1vSrKB2G8htK6rZAJ +Ytra1wc900fJQL9npa61NxxHRkjoKQUZT0xwrgU3/+7yZpDFBxiBIzLAE5N6GqbRThh ICtFIh15P7woDJZJtGGrIl9vhXSvLGKWz0zKp8mUXWJFv45xVSLkvTnBVfc5/eE0r6Tz pWeg== X-Gm-Message-State: APjAAAV0pqsYt7+Gfgz9laEHX/Mu1AWnN1RqRdhyuBTmZjpDbN4f5/NN EM+eW7mMMGjuF9Zx6KmQS3QpqQy/k5MrsQJbVH1wsQ== X-Google-Smtp-Source: APXvYqxmuSL0hteFTupUjJn3wUN3kcHsQP9rIYmoxW19WvjEH30AU+ksa0O6R0/8x8TO4EBd+97rum1aVOZ9w4stMaw= X-Received: by 2002:a05:6214:b92:: with SMTP id fe18mr1926044qvb.118.1582855320739; Thu, 27 Feb 2020 18:02:00 -0800 (PST) MIME-Version: 1.0 References: <202002280118.01S1IBRl044620@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Thu, 27 Feb 2020 19:01:46 -0700 Message-ID: Subject: Re: svn commit: r358417 - head/sys/cam To: Benjamin Kaduk Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 48TCTW4bfJz4qv6 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=qZUu8ZCY; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f33) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.91 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-1.91)[ip: (-5.96), ipnet: 2607:f8b0::/32(-1.88), asn: 15169(-1.67), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 02:02:08 -0000 On Thu, Feb 27, 2020, 6:27 PM Benjamin Kaduk wrote: > On Thu, Feb 27, 2020 at 5:18 PM Warner Losh wrote: > >> Author: imp >> Date: Fri Feb 28 01:18:11 2020 >> New Revision: 358417 >> URL: https://svnweb.freebsd.org/changeset/base/358417 >> >> Log: >> This is a FALLTHROUGH for sure. no need for xxx comment. >> >> Modified: >> head/sys/cam/cam_xpt.c >> >> Modified: head/sys/cam/cam_xpt.c >> >> ============================================================================== >> --- head/sys/cam/cam_xpt.c Fri Feb 28 01:02:01 2020 (r358416) >> +++ head/sys/cam/cam_xpt.c Fri Feb 28 01:18:11 2020 (r358417) >> @@ -2690,7 +2690,7 @@ xpt_action_default(union ccb *start_ccb) >> case XPT_NVME_ADMIN: >> /* FALLTHROUGH */ >> case XPT_MMC_IO: >> - /* XXX just like nmve_io? */ >> + /* FALLTHROUGH */ >> case XPT_RESET_DEV: >> case XPT_ENG_EXEC: >> case XPT_SMP_IO: >> >> > Okay, I'll bite. Why do XPT_NVME_ADMIN and XPT_MMC_IO get "FALLTHROUGH" > comments but XPT_RESET_DEV and XPT_ENG_EXEC just get listed as part of the > same grouping as XPT_SMP_IO? > Good question. I just fixed a dubious xxx comment, but you mat be right. Warner >