From owner-freebsd-hackers@FreeBSD.ORG  Tue Jul  6 14:47:02 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 58C6E16A4CE; Tue,  6 Jul 2004 14:47:02 +0000 (GMT)
Received: from smtp.des.no (flood.des.no [217.116.83.31])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B3BF943D55; Tue,  6 Jul 2004 14:47:01 +0000 (GMT)
	(envelope-from des@des.no)
Received: by smtp.des.no (Pony Express, from userid 666)
	id 8F015531C; Tue,  6 Jul 2004 16:47:00 +0200 (CEST)
Received: from dwp.des.no (des.no [80.203.228.37])
	by smtp.des.no (Pony Express) with ESMTP
	id 0B212531B; Tue,  6 Jul 2004 16:46:53 +0200 (CEST)
Received: by dwp.des.no (Postfix, from userid 2602)
	id DCB9DB860; Tue,  6 Jul 2004 16:46:52 +0200 (CEST)
To: Xin LI <delphij@frontfree.net>
References: <20040625033718.GA1691@frontfree.net> <xzpn02d9wxh.fsf@dwp.des.no>
	<20040706144102.GA4034@frontfree.net>
From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=)
Date: Tue, 06 Jul 2004 16:46:52 +0200
In-Reply-To: <20040706144102.GA4034@frontfree.net> (Xin LI's message of
 "Tue, 6 Jul 2004 22:41:02 +0800")
Message-ID: <xzpy8lx8a77.fsf@dwp.des.no>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on flood.des.no
X-Spam-Level: 
X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.63
cc: hackers@FreeBSD.org
cc: doc@FreeBSD.org
Subject: Re: About rules on style changes
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jul 2004 14:47:02 -0000

Xin LI <delphij@frontfree.net> writes:
> Hmm... Seems that I have misunderstood the committers' guide, section
> 10.3, which said:
>
> "Do not mix style fixes with new functionality. A style fix is any
> change which does not modify the functionality of the code. Mixing the
> changes obfuscates the functionality change when using cvs diff, which
> can hide any new bugs."

That just means you have to do it in a separate commit.  We do not
generally make style changes for their own sake; instead, we commit
style fixes shortly before or after a functional change.

DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no