From owner-freebsd-net@freebsd.org Sun Jan 24 15:43:44 2021 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8EE7F4FFD25 for ; Sun, 24 Jan 2021 15:43:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DNy2m3STQz3hrZ for ; Sun, 24 Jan 2021 15:43:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 769304FFD24; Sun, 24 Jan 2021 15:43:44 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 765C74FFC24 for ; Sun, 24 Jan 2021 15:43:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DNy2m2s9tz3hrW for ; Sun, 24 Jan 2021 15:43:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 550C225B64 for ; Sun, 24 Jan 2021 15:43:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 10OFhiGS066644 for ; Sun, 24 Jan 2021 15:43:44 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 10OFhiVf066643 for net@FreeBSD.org; Sun, 24 Jan 2021 15:43:44 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 250499] [tcp] Should we reject the packet with timestamp if no timestamp in SYN and SYN_ACK? Date: Sun, 24 Jan 2021 15:43:44 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: standards X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Flags: mfc-stable12+ mfc-stable11+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jan 2021 15:43:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D250499 --- Comment #6 from Michael Tuexen --- (In reply to Roman Bogorodskiy from comment #5) Hi Roman, I introduced a regression, which was fixed in https://cgit.FreeBSD.org/src/commit/?id=3Dcc3c34859eab1b317d0f38731355b53f7= d978c97 and MFCed to stable/12 in https://cgit.FreeBSD.org/src/commit/?id=3Dd05d908d6d3c85479c84c707f93114843= 9ae826b. This was affecting the handling of received TCP RST segments. Does this fix your issue? In bug #252449 it was reported that there are broken TCP stacks, which negotiate TCP timestamp support but then don't behave as required. To deal with such broken implementations I added a sysctl variable in https://cgit.FreeBSD.org/src/commit/?id=3Dd2b3ceddccac60b563f642898e3a31464= 7666a10 , which was MFCed to stable/12 in https://cgit.FreeBSD.org/src/commit/?id=3De82353f84c58da9a5c38bd471a09936c1= 6a5b6ea. In this case you can set the sysctl variable net.inet.tcp.tolerate_missing_= ts to 1. I would be interested to now which stack is broken and it would be gr= eat if you could provide a .pcap file of the failing TCP connection. Does this fix your issue? --=20 You are receiving this mail because: You are on the CC list for the bug.=