Date: Mon, 10 Oct 2011 23:40:08 GMT From: Garrett Cooper <yanegomi@gmail.com> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/161452: [patch] make PORTS_MODULES compile more sane with proper OSVERSION / SRC_BASE values (fwd) Message-ID: <201110102340.p9ANe8mF030512@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/161452; it has been noted by GNATS.
From: Garrett Cooper <yanegomi@gmail.com>
To: bug-followup@FreeBSD.org
Cc:
Subject: Re: kern/161452: [patch] make PORTS_MODULES compile more sane with
proper OSVERSION / SRC_BASE values (fwd)
Date: Mon, 10 Oct 2011 16:32:01 -0700 (PDT)
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
--967339439-965045101-1318204343=:4348
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; FORMAT=flowed
Content-ID: <alpine.BSF.2.00.1110091657352.4348@toaster.local>
The issue with the previous version was the patch was that it
didn't actually dig into ${MAKEOBJDIRPREFIX} to try and dig up osreldate.h
(this was because I dug up the pattern from src/Makefile.inc1 without
looking at the input file first).
I have adjusted ${MAKEOBJDIRPREFIX}'s permissions s.t. I can build
to that directory. Furthermore, multiple KERNCONFs can be built with
conflicting or differing options. Thus, it's smarter to setup the port to
build under ${MAKEOBJDIRPREFIX}${SRC_BASE}/sys/${KERNCONF}, etc. Please
note that this proposed change doesn't fix all issues, but it takes a
first step towards a more sane status quo:
1. According to a quick glance in x11/nvidia-driver where it uses
/boot/modules and assumes that nvidia.ko will be valid for all kernels.
The tricky problem to resolve is dealing with packaging metadata, as the
last install for the module will effectively win, canceling out the rest
of the install metadata for the other kernels. Thus, /boot/modules will
have to remain for now.
2. With newly installed modules, it will duplicate a lot of
dependent port installs under
${MAKEOBJDIRPREFIX}${SRC_BASE}/sys/${KERNCONF} . This is
inefficient and not ideal.
Thanks,
-Garrett
--967339439-965045101-1318204343=:4348
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=make-PORTS_MODULES-compile-sane.patch
Content-Transfer-Encoding: BASE64
Content-ID: <alpine.BSF.2.00.1110101632010.4348@toaster.local>
Content-Description:
Content-Disposition: attachment; filename=make-PORTS_MODULES-compile-sane.patch
SW5kZXg6IHN5cy9jb25mL2tlcm4ucG9zdC5taw0KPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQ0KLS0tIHN5cy9jb25mL2tlcm4ucG9zdC5tawkocmV2aXNpb24g
MjI2MTcxKQ0KKysrIHN5cy9jb25mL2tlcm4ucG9zdC5tawkod29ya2luZyBj
b3B5KQ0KQEAgLTM4LDEyICszOCwyMiBAQA0KIA0KICMgSGFuZGxlIG91dCBv
ZiB0cmVlIHBvcnRzIA0KIC5pZiAhZGVmaW5lZChOT19NT0RVTEVTKSAmJiBk
ZWZpbmVkKFBPUlRTX01PRFVMRVMpDQotUE9SVFNNT0RVTEVTRU5WPVNZU0RJ
Uj0ke1NZU0RJUn0NCisuaWYgIWRlZmluZWQoU1JDX0JBU0UpDQorU1JDX0JB
U0UhPQlyZWFscGF0aCAiJHtTWVNESVI6SH0vIg0KKy5lbmRpZg0KKy5pZiAh
ZGVmaW5lZChPU1JFTERBVEUpDQorT1NSRUxEQVRFIT0JYXdrICcvXlwjZGVm
aW5lW1s6c3BhY2U6XV0qX19GcmVlQlNEX3ZlcnNpb24vIHsgcHJpbnQgJCQz
IH0nIFwNCisJCSR7TUFLRU9CSkRJUlBSRUZJWH0ke1NSQ19CQVNFfS9pbmNs
dWRlL29zcmVsZGF0ZS5oDQorLmVuZGlmDQorUE9SVFNNT0RVTEVTRU5WPU9T
VkVSU0lPTj0ke09TUkVMREFURX0gXA0KKwkJUEFUSD0iJHtQQVRIfTovdXNy
L2xvY2FsL2JpbiIgXA0KKwkJU1JDX0JBU0U9IiR7U1JDX0JBU0V9Ig0KKw0K
IC5mb3IgX190YXJnZXQgaW4gYWxsIGluc3RhbGwgcmVpbnN0YWxsIGNsZWFu
DQogJHtfX3RhcmdldH06IHBvcnRzLSR7X190YXJnZXR9DQogcG9ydHMtJHtf
X3RhcmdldH06DQogLmZvciBfX2kgaW4gJHtQT1JUU19NT0RVTEVTfQ0KLQlj
ZCAkJHtQT1JUU0RJUjotL3Vzci9wb3J0c30vJHtfX2l9OyAke1BPUlRTTU9E
VUxFU0VOVn0gJHtNQUtFfSAtQiAke19fdGFyZ2V0OkMvaW5zdGFsbC9kZWlu
c3RhbGwgcmVpbnN0YWxsLzpDL3JlaW5zdGFsbC9kZWluc3RhbGwgcmVpbnN0
YWxsL30NCisJY2QgJCR7UE9SVFNESVI6LS91c3IvcG9ydHN9LyR7X19pfTsg
JHtQT1JUU01PRFVMRVNFTlZ9IFdSS0RJUlBSRUZJWD0iJHtNQUtFT0JKRElS
UFJFRklYfSR7U1JDX0JBU0V9L3N5cy8ke0tFUk5DT05GfS8ke19faX0iICR7
TUFLRX0gLUIgJHtfX3RhcmdldDpDL2luc3RhbGwvZGVpbnN0YWxsIHJlaW5z
dGFsbC86Qy9yZWluc3RhbGwvZGVpbnN0YWxsIHJlaW5zdGFsbC99DQogLmVu
ZGZvcg0KIC5lbmRmb3INCiAuZW5kaWYNCg==
--967339439-965045101-1318204343=:4348--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110102340.p9ANe8mF030512>