From owner-svn-src-all@FreeBSD.ORG Fri Jun 11 09:27:17 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 72555106566B; Fri, 11 Jun 2010 09:27:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id DD52C8FC08; Fri, 11 Jun 2010 09:27:16 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o5B9R96g083425 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 11 Jun 2010 12:27:09 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o5B9R9wK092045; Fri, 11 Jun 2010 12:27:09 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o5B9R9Cj092044; Fri, 11 Jun 2010 12:27:09 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 11 Jun 2010 12:27:09 +0300 From: Kostik Belousov To: Alexander Motin Message-ID: <20100611092709.GG2401@deviant.kiev.zoral.com.ua> References: <201006101614.o5AGE5Zh099383@svn.freebsd.org> <20100611083137.GA2401@deviant.kiev.zoral.com.ua> <4C11FD57.2000400@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="L1c6L/cjZjI9d0Eq" Content-Disposition: inline In-Reply-To: <4C11FD57.2000400@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_50, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r208988 - in head/sys: kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2010 09:27:17 -0000 --L1c6L/cjZjI9d0Eq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 11, 2010 at 12:09:43PM +0300, Alexander Motin wrote: > Kostik Belousov wrote: > > On Thu, Jun 10, 2010 at 04:14:05PM +0000, Alexander Motin wrote: > >> Author: mav > >> Date: Thu Jun 10 16:14:05 2010 > >> New Revision: 208988 > >> URL: http://svn.freebsd.org/changeset/base/208988 > >> > >> Log: > >> Store interrupt trap frame into struct thread. It allows interrupt h= andler > >> to obtain both trap frame and opaque argument submitted on registrct= ion. > >> After kernel and all drivers get used to it, legacy hack can be remo= ved. > >> =20 > >> Reviewed by: jhb@ > > Just curious, why td_frame is not enough for your usage ? I believe td_= frame > > is currently set only by traps and syscalls, and copied on forks. Correction: and ast(). >=20 > I've seen that field, but I have no idea how it is used. I see a lot of > usage places and not sure that none of them called inside interrupt > filter. I didn't want to break something unexpected. If you sure - it is > easy to change. I believe it is safe to use it in a way that you intended to use td_intr_frame. In the current code, interrupt handler cannot rely on the content of td_frame, your save/restore brackets should do the right thing. --L1c6L/cjZjI9d0Eq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkwSAW0ACgkQC3+MBN1Mb4i6tQCfciXOdas8KQmC0W60lnF7GUNf 2A0An1bkq+dl2HBh5fGDiPlzDVnOstbZ =5w3x -----END PGP SIGNATURE----- --L1c6L/cjZjI9d0Eq--