From owner-svn-src-head@freebsd.org Thu Apr 6 12:54:56 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6852ED2F038; Thu, 6 Apr 2017 12:54:56 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 22702269; Thu, 6 Apr 2017 12:54:55 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id w6w2cT0HXjkXyw6w3cB4tf; Thu, 06 Apr 2017 06:54:48 -0600 X-Authority-Analysis: v=2.2 cv=KeeiiUQD c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=8nJEP1OIZ-IA:10 a=AzvcPWV-tVgA:10 a=BWvPGDcYAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=MenKANog2wuEQgPJdsEA:9 a=wPNLvfGTeEIA:10 a=pxhY87DP9d2VeQe4joPk:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 39529AEF; Thu, 6 Apr 2017 05:54:46 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v36CsjSl008801; Thu, 6 Apr 2017 05:54:45 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201704061254.v36CsjSl008801@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= cc: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316487 - head/etc In-Reply-To: Message from =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= of "Thu, 06 Apr 2017 09:50:58 +0200." <868tne3rfh.fsf@desk.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Date: Thu, 06 Apr 2017 05:54:45 -0700 X-CMAE-Envelope: MS4wfAYcQHKPjv/boYfMwU4apedbdkroLqO0FtdkzXMxpQPu6BMLN6avIHxRWohT+2MdHtws8Kq2n0g2tRaggLhkMD2034lxsfr80ILZq7rwhNXbmBG9Vpl9 1tFI6I38zb5JeROrhpJGRCESYqeED0uclXiyFj8pdfgZAeZUSB8D8SCd97Y2IdlSSO8eX1MdOsY96Hb+PeoqOQTAq1SqeLAudxrNdFaQFFndScnuL5vhOPHK EP8eOlRi2h3VgFm0l2ies9+GUJavp0duCevPMnRpRgc= X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 12:54:56 -0000 In message <868tne3rfh.fsf@desk.des.no>, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav? = w rites: > Cy Schubert writes: > > Dag-Erling Smørgrav writes: > > > Could you please revert? > > Sure, it's been reverted. > > No, you misunderstood... I meant revert *my* commit. I didn't know it > had already been fixed (for some value of fixed) when I wrote this. It's reverted now. > > > Are you thinking of a more intrusive change like my first draft of the > > patch? > > Sorry, haven't looked at your patch. Mine adds check_debug, check_force > etc. and uses them everywhere. > > Note that none of these variables are documented, so using them outside > of rc.subr itself is arguably a bug. Agreed. Regardless, an UPDATING entry will still be needed because ports and third party software may have the same "bug" as rc.d/dhclient and rc.d/bgfsck. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.