From owner-svn-src-all@freebsd.org  Wed Apr 13 04:21:14 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C500B0E112;
 Wed, 13 Apr 2016 04:21:14 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: from mail-pf0-x22a.google.com (mail-pf0-x22a.google.com
 [IPv6:2607:f8b0:400e:c00::22a])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 6557F1D3F;
 Wed, 13 Apr 2016 04:21:14 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: by mail-pf0-x22a.google.com with SMTP id e128so26500678pfe.3;
 Tue, 12 Apr 2016 21:21:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:subject:from:in-reply-to:date:cc
 :content-transfer-encoding:message-id:references:to;
 bh=ZKpssLm18wBFQKnmDM4WWFZA3Zq5zflQ/w7VxBtveNI=;
 b=nowL3r+mkg+Ke/OlMrL/JsCnJ9gDiIg0bnb1snakPWUDFKtakpyk7yRVgKuAqTU5OM
 mar/BT3ZNMSw3sjmZLjPZdIiQaPmeooFrvofTR6H2E0W58iPhRntjjm5tIgWNeYr1YuU
 OG6nrQ+XLlp02Z91FTHMmQlccN91LIWZ010StCX7j3gTQ7hRSuO+InhYZaxo47k+wefA
 2v28y5Bx9aZvN8NpuB7IA4ucgWK1acCOlqEmi3Jlv4PwWsoDNM/zNthbvfKaIcVsxIBY
 1+TR+2842S0A8dqgL1Ro+svB9UbJI83Uyso9z7h9Z1o9HiF92eiqA4t8W6j7MHXmcScW
 KCvA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc
 :content-transfer-encoding:message-id:references:to;
 bh=ZKpssLm18wBFQKnmDM4WWFZA3Zq5zflQ/w7VxBtveNI=;
 b=JrXIbuLOj1XcEk7ABXkCFnfSqGovgdXbvw1iHC+0tT0MPr0B1orgtefbhghxVqe7P4
 PyCv1SyouWIh2a+7B8peDNBJwXurEIR/IboyVefBXRoH+92moFiCTWdAUbN6p7ATFqEZ
 FGa57nl+MJHRk8JlO97ZwNnCVQyF43kqqeiDinGEr05tqlh8DVg6S/3szGS9sA2VFaKs
 Vj9dnBC7S4gk8XgCjYioJZXgjeUa2925tmxV6HIoOf2v77lokRaKQlKwvZUOQCA9yU+k
 a79VHWTzCH3su2fosE25YUWr52bLawcX7/RLgZsYCS4gCJSe45n8sTrGijHC64vxb0TM
 TOeQ==
X-Gm-Message-State: AOPr4FVytdx4RTpzZdAAVPw+KUFfisjdMDAqKMownhjda8M84DaYo3rig0y5g6Mj4dHdjQ==
X-Received: by 10.98.44.70 with SMTP id s67mr9904822pfs.59.1460521273909;
 Tue, 12 Apr 2016 21:21:13 -0700 (PDT)
Received: from [29.143.40.241] ([172.58.40.174])
 by smtp.gmail.com with ESMTPSA id l11sm47058748pfb.56.2016.04.12.21.21.12
 (version=TLSv1/SSLv3 cipher=OTHER);
 Tue, 12 Apr 2016 21:21:12 -0700 (PDT)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (1.0)
Subject: Re: svn commit: r297902 - head
From: NGie Cooper <yaneurabeya@gmail.com>
X-Mailer: iPhone Mail (13E238)
In-Reply-To: <570DB6C7.6050201@FreeBSD.org>
Date: Tue, 12 Apr 2016 21:21:11 -0700
Cc: Steve Wills <swills@FreeBSD.org>, Ian Lepore <ian@freebsd.org>,
 src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: 7bit
Message-Id: <1A172401-6B7B-4099-A4C9-228FB4EBFDDB@gmail.com>
References: <201604130147.u3D1l5F0032629@repo.freebsd.org>
 <1460512755.52955.18.camel@freebsd.org> <570DB63F.9060907@FreeBSD.org>
 <570DB6C7.6050201@FreeBSD.org>
To: Bryan Drewery <bdrewery@FreeBSD.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Apr 2016 04:21:14 -0000


> On Apr 12, 2016, at 20:02, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
> 
>> On 4/12/2016 8:00 PM, Steve Wills wrote:
>>> On 04/12/16 09:59 PM, Ian Lepore wrote:
>>> 
>>> More succinctly:
>>> 
>>> .if empty(SVN)
>>> SVN!= which svn || which svnlite
>>> .endif
>> 
>> Fair enough, that's basically the intent. I think we like to avoid !=,
>> at least in ports, and I wanted the logic between src and ports to match
>> in this case.
> 
> Yeah, please avoid != where possible.
> 
> If you switch to this then also add .export SVN after the SVN!= line.
> 
> I somewhat like this version more though since /usr/local/bin may not be
> in the PATH.

Plus it's not set in PATH probably in this portion of the build...