From owner-freebsd-current@FreeBSD.ORG  Thu Jun 26 23:58:27 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9BE4937B401; Thu, 26 Jun 2003 23:58:27 -0700 (PDT)
Received: from spider.deepcore.dk
	(cpe.atm2-0-56339.0x50c6aa0a.abnxx2.customer.tele.dk [80.198.170.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0DCCF43FD7; Thu, 26 Jun 2003 23:58:26 -0700 (PDT)
	(envelope-from sos@spider.deepcore.dk)
Received: (from sos@localhost)
	by spider.deepcore.dk (8.12.8p1/8.12.8) id h5R6wA1K061285;
	Fri, 27 Jun 2003 08:58:10 +0200 (CEST)
	(envelope-from sos)
From: Soeren Schmidt <sos@spider.deepcore.dk>
Message-Id: <200306270658.h5R6wA1K061285@spider.deepcore.dk>
In-Reply-To: <20030626234558.ECF8C37B401@hub.freebsd.org>
To: Bill Paul <wpaul@FreeBSD.ORG>
Date: Fri, 27 Jun 2003 08:58:10 +0200 (CEST)
X-Mailer: ELM [version 2.4ME+ PL98b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=ISO-8859-1
cc: Ian Dowse <iedowse@maths.tcd.ie>
cc: current@FreeBSD.ORG
cc: imp@bsdimp.com
Subject: Re: Heads up: checking in change to ata-card.c
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Jun 2003 06:58:27 -0000

It seems Bill Paul wrote:
> > In message <20030626.131417.101814768.imp@bsdimp.com>, "M. Warner Losh" writes:
> > >Here's a better patch, basesd on wpaul's input.  Bill, can you try it
> > >an see if it works for you?  If so, i would be better to commit this
> > >one.  If not, I'll work with you to fix it. 
> > 
> > FYI, I have a no-name ("PCMCIA"/"CD-ROM") drive that also requires
> > failure of the second IO range to be made non-fatal. How about just
> > deleting the `else' clause as in the patch below? It seems that
> > this can only affect CD-ROM drives that were otherwise not working,
> > so it should be fairly safe.
> 
> This patch also tests good with my drive.

Thats what I proposed on the unnamed IRC channel yesterday, its fine by
me as well, can we agree to commit just this then ?

> > Index: ata-card.c
> > ===================================================================
> > RCS file: /dump/FreeBSD-CVS/src/sys/dev/ata/ata-card.c,v
> > retrieving revision 1.14
> > diff -u -r1.14 ata-card.c
> > --- ata-card.c	17 Jun 2003 12:33:53 -0000	1.14
> > +++ ata-card.c	26 Jun 2003 23:00:01 -0000
> > @@ -131,10 +131,6 @@
> >  			     start + ATA_ALTOFFSET, ATA_ALTIOSIZE);
> >  	}
> >      }
> > -    else {
> > -	bus_release_resource(dev, SYS_RES_IOPORT, rid, io);
> > -	return ENXIO;
> > -    }
> >  
> >      /* allocate the altport range */
> >      rid = ATA_ALTADDR_RID;

-Søren