From owner-dev-commits-src-all@freebsd.org Thu Jan 28 07:50:26 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 260144FB6D7; Thu, 28 Jan 2021 07:50:26 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DRCLp0ShDz4l3J; Thu, 28 Jan 2021 07:50:26 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id DC0D42E585; Thu, 28 Jan 2021 07:50:25 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id BF12B5580E; Thu, 28 Jan 2021 08:50:23 +0100 (CET) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_8111A1CC-7112-4206-951D-1A86CB64A0F0"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: Re: git: 6e26189be406 - main - Fix loader detection of vbefb support on !amd64 Date: Thu, 28 Jan 2021 08:50:16 +0100 In-Reply-To: <3973a397-1250-1230-fecc-956b84c74fc9@FreeBSD.org> Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" To: John Baldwin References: <202101272129.10RLTAee080408@gitrepo.freebsd.org> <3973a397-1250-1230-fecc-956b84c74fc9@FreeBSD.org> X-Mailer: Apple Mail (2.3445.104.17) X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2021 07:50:26 -0000 --Apple-Mail=_8111A1CC-7112-4206-951D-1A86CB64A0F0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 28 Jan 2021, at 00:08, John Baldwin wrote: >=20 > On 1/27/21 1:29 PM, Dimitry Andric wrote: >> The branch main has been updated by dim: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D6e26189be406a9a3799074b16925e6cd= 63cc703b >> commit 6e26189be406a9a3799074b16925e6cd63cc703b >> Author: Dimitry Andric >> AuthorDate: 2021-01-27 21:28:43 +0000 >> Commit: Dimitry Andric >> CommitDate: 2021-01-27 21:28:43 +0000 >> Fix loader detection of vbefb support on !amd64 >> On i386, after 6c7a932d0b8baaaee16eca0ba061bfa6e0e57bfd, the = vbefb vt >> driver was no longer detected by the loader, if any kernel module = was >> loaded after the kernel itself. >> This was caused by the parse_vt_drv_set() function being = called multiple >> times, resetting the detection flag. (It was called multiple = times, >> becuase i386 .ko files are shared objects like the kernel proper, = while >> this is not the case on amd64.) >> Fix this by skipping the set_vt_drv_set lookup if vbefb was = already >> detected. >> Reviewed by: tsoome >=20 > Does the state get reset if you unload one kernel and then load a = different > one (e.g. via interactive 'unload' and 'load /path/to/my/kernel')? Ha, good one! I don't think it is. -Dimitry --Apple-Mail=_8111A1CC-7112-4206-951D-1A86CB64A0F0 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCYBJsuAAKCRCwXqMKLiCW o993AJ0f6St0I69LSbg5bxurOkKtbulmOACgsAn5QTLI+4tbsDK/siplzMup1m0= =24sf -----END PGP SIGNATURE----- --Apple-Mail=_8111A1CC-7112-4206-951D-1A86CB64A0F0--