From owner-svn-src-head@freebsd.org Fri Apr 6 01:20:53 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB185F92E4F; Fri, 6 Apr 2018 01:20:52 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f44.google.com (mail-it0-f44.google.com [209.85.214.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 814637BB15; Fri, 6 Apr 2018 01:20:52 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f44.google.com with SMTP id h143-v6so4870036ita.4; Thu, 05 Apr 2018 18:20:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=/R4YNQiGbc/hpwXkslh3X6H58lCsMMInmc/Uwb6xY1M=; b=GFW2GZDn76WUiQ3P/xPFnPUIcGo2qP7HjRWcEACDdS9D8p/VYUr4jkDBsIJbqTlZPh POQlxAoEjzuckIK/L7ML+nD2JSKUVnV/CVD3Bsx1SNAUVAKzC1r6pNdSsFCEELSik6IU un3AsAE6DPE7/3eNn0YHGXzfnPuBUCNBuriwBXgMXy9fj6B0d2WKBFw8yFzQtkOq4RBX hyxxPhRxb9SLnWvUdxyIN9rTKafvZI1jZDKh0VzpPYLGWZcKrtVv5986h5JOUXNf9+fn IhlKakhnb5pbBl7Lhi5ErvEEAmwsjEydUclU0ddSGCVJfnUFHrdBYFvW0V1RUvxxtR46 7qdw== X-Gm-Message-State: ALQs6tDEHQLiVxjQZHWbLrPhYFhhjoUpzUqkST+EJQgZ6DTj4EzLnEDj Wjy1j7Iy2TFW6mgw2BD+UL7LoGQZ X-Google-Smtp-Source: AIpwx49zAlSGv87o26QClhvAap3P7dYHQSAH3tlJzudOInQMePneW6cSy4blC9pKYfE2TJPkHJqmug== X-Received: by 2002:a24:730e:: with SMTP id y14-v6mr15882260itb.70.1522977651501; Thu, 05 Apr 2018 18:20:51 -0700 (PDT) Received: from mail-io0-f177.google.com (mail-io0-f177.google.com. [209.85.223.177]) by smtp.gmail.com with ESMTPSA id t10sm5720986ioa.29.2018.04.05.18.20.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Apr 2018 18:20:51 -0700 (PDT) Received: by mail-io0-f177.google.com with SMTP id q84so32798009iod.10; Thu, 05 Apr 2018 18:20:51 -0700 (PDT) X-Received: by 10.107.168.78 with SMTP id r75mr22626481ioe.143.1522977651146; Thu, 05 Apr 2018 18:20:51 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.62.19 with HTTP; Thu, 5 Apr 2018 18:20:50 -0700 (PDT) In-Reply-To: <4cd9a49c-2d75-bfac-20df-72e8c80eded4@freebsd.org> References: <201804051356.w35Duexg022529@repo.freebsd.org> <4cd9a49c-2d75-bfac-20df-72e8c80eded4@freebsd.org> From: Conrad Meyer Date: Thu, 5 Apr 2018 18:20:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r332070 - in head/sys/geom: . label raid To: Allan Jude Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 01:20:53 -0000 On Thu, Apr 5, 2018 at 6:08 PM, Allan Jude wrote: > On 2018-04-05 09:56, Sean Bruno wrote: >> Author: sbruno >> Date: Thu Apr 5 13:56:40 2018 >> New Revision: 332070 >> URL: https://svnweb.freebsd.org/changeset/base/332070 >> >> Log: >> Squash error from geom by sizing ident strings to DISK_IDENT_SIZE. >> >> ... > I might be missing something here, but it seems like you didn't actually > change the side of > ... > struct md_s The md side can be as small as it likes. It's the caller who needs to provide the large buffer, for other providers of the GEOM::ident attribute. > And I don't see where the destination buffer went from 24 bytes to a > larger value. Check the change in md_intel.c. Best, Conrad