From owner-cvs-all Tue Aug 31 15: 8:11 1999 Delivered-To: cvs-all@freebsd.org Received: from emmi.physik.TU-Berlin.DE (emmi.physik.TU-Berlin.DE [130.149.160.103]) by hub.freebsd.org (Postfix) with ESMTP id D75CE15BBC; Tue, 31 Aug 1999 15:07:53 -0700 (PDT) (envelope-from ibex@emmi.physik.TU-Berlin.DE) Received: (from ibex@localhost) by emmi.physik.TU-Berlin.DE (8.9.3/8.9.3) id AAA89396; Wed, 1 Sep 1999 00:07:23 +0200 (CEST) (envelope-from ibex) Date: Wed, 1 Sep 1999 00:07:23 +0200 From: Dirk Froemberg To: Bill Fumerola Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: ports/www/apache13-php4/patches patch-ag Message-ID: <19990901000723.A88853@physik.TU-Berlin.DE> References: <199908311249.FAA15121@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4i In-Reply-To: <199908311249.FAA15121@freefall.freebsd.org>; from Bill Fumerola on Tue, Aug 31, 1999 at 05:49:53AM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Did you ever hear the word "MAINTAINER"? No? You should! Perhaps you want to read http://www.freebsd.org/handbook/policies.html#POLICIES-MAINTAINER for an explanation. In this document - as well as in the "Proposed rules for committers" - there is something about "reviewing". In this special case your commit is counterproductive because I'm currently working on this file. (Your change was already included). So a needed 'cvs update' discards some of my changes. I have to reintegrate them manually afterwards. And your commit produces unneccessary CVS, mail etc. overhead, because I have to change the same file. A short mail ("Hey, Dirk. application/x-httpd-php3{,-source} should be application/x-httpd-php{,-source} in www/apache13-php4/patches/patch-ag.") would have been much better... *sigh* On Tue, Aug 31, 1999 at 05:49:53AM -0700, Bill Fumerola wrote: > billf 1999/08/31 05:49:53 PDT > > Modified files: > www/apache13-php4/patches patch-ag > Log: > Use the correct mime-type for php files. No php would ever work in > this port without this update. > > Obtained from: http://www.php.net/version4/migration.php > > Revision Changes Path > 1.6 +2 -2 ports/www/apache13-php4/patches/patch-ag > -- e-mail: dirk@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message