From owner-freebsd-current Sat Sep 14 12:26:57 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ECFAA37B400 for ; Sat, 14 Sep 2002 12:26:55 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 9652843E42 for ; Sat, 14 Sep 2002 12:26:55 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 32407 invoked by uid 1000); 14 Sep 2002 19:26:56 -0000 Date: Sat, 14 Sep 2002 12:26:56 -0700 (PDT) From: Nate Lawson To: Maxime Henrion Cc: current@freebsd.org Subject: Re: patch: remove vestiges of nfs_mount_type In-Reply-To: <20020914101551.GT86074@elvis.mu.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 14 Sep 2002, Maxime Henrion wrote: > Nate Lawson wrote: > > Problems with this? It is never initialized and referenced exactly once. > > This will make this code to be run for every VFCF_NETWORK filesystem > instead of just NFS, so it is probably worth testing if it doesn't cause > problems with smbfs and nwfs. It might be interesting to see why this > was done in the first place. > > Cheers, > Maxime Yes, I agree. BTW, the recent v_tag commit uses VFCF_NETWORK in two places so a review of those as well would help also. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message