Date: Thu, 30 Oct 2003 12:34:24 +0100 From: Clement Laforet <sheepkiller@cultdeadsheep.org> To: Oliver Eikemeier <eikemeier@fillmore-labs.com> Cc: cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/www/apache2 Message-ID: <20031030123424.7da91ffe.sheepkiller@cultdeadsheep.org> In-Reply-To: <3FA0F01E.5040107@fillmore-labs.com> References: <200310292246.h9TMkjSI062232@repoman.freebsd.org> <3FA05A25.2020408@fillmore-labs.com> <20031030013046.26bb944c.sheepkiller@cultdeadsheep.org> <20031029233231.V7442@blues.jpj.net> <3FA0F01E.5040107@fillmore-labs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 30 Oct 2003 12:03:58 +0100
Oliver Eikemeier <eikemeier@fillmore-labs.com> wrote:
> I can't find any conflicts with the caudium* ports, and www/mini_httpd
> is missing. How about:
<snip>
my CONFLICTS lines seems to have disappeared when I merge my devel ports
and one in CVS tree. Surely due to dinoex's changes.
Added to TODO list.
>
>
> > +# WITH_PORT default: 80
>
> I'm fine with that, even though WITH_HTTP_PORT seems more appealing to
> me.
ok
>
> > +# WITHOUT_ERROR: Do not install www/error
>
> I would make this the default ;-) Honestly: there must be a better
> name for it. Do we need that many options?
WITHOUT_ERROR_SAMPLES maybe...
About the "many options", I can introduce a WITH_CUSTOM_WWW, like WITH_CUSTOM_PROXY.
WITH_CUSTOM_WWW= [error|wwwdata|cgi|icons]
>
> > .if defined(WITH_LDAP)
> > USE_LDAP= YES
>
> That doesn't seem to work, it's USE_OPENLDAP as far as I can remember.
yep. where's my head ? :)
>
> > + @${ECHO}
> > + @${ECHO_MSG} "*** To see all available knobs, type: make
> > show-options"+ @${ECHO}
> Mixing ECHO and ECHO_MSG is strange, how about using ECHO here?
remaining of developpement ;-) I was too focused on modules handling :-)
Added to TODO list
> > show-options:
> > @${EGREP} '^##' ${.CURDIR}/Makefile | ${SED} 's/##//'
>
> Not that I particularly like this, but how about using:
> @${SED} -ne 's/^##//p' ${.CURDIR}/Makefile
Why not... (but it get rid of the header and footer blank line)
I have some minor cleaning to add to Makefile.modules
I'll surely submit PORTREVISION 1 this afternoon.
clem
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031030123424.7da91ffe.sheepkiller>