From owner-svn-src-all@FreeBSD.ORG Thu Sep 18 06:13:30 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E80BF8C8; Thu, 18 Sep 2014 06:13:30 +0000 (UTC) Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ns.kevlo.org", Issuer "ns.kevlo.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 874DDB4; Thu, 18 Sep 2014 06:13:29 +0000 (UTC) Received: from ns.kevlo.org (localhost [127.0.0.1]) by ns.kevlo.org (8.14.8/8.14.8) with ESMTP id s8I64a56005866 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 18 Sep 2014 14:04:37 +0800 (CST) (envelope-from kevlo@ns.kevlo.org) Received: (from kevlo@localhost) by ns.kevlo.org (8.14.8/8.14.8/Submit) id s8I64aMJ005865; Thu, 18 Sep 2014 14:04:36 +0800 (CST) (envelope-from kevlo) Date: Thu, 18 Sep 2014 14:04:35 +0800 From: Kevin Lo To: Gleb Smirnoff Subject: Re: svn commit: r271735 - head/sys/net Message-ID: <20140918060435.GA5856@ns.kevlo.org> References: <201409180309.s8I39Zmh045601@svn.freebsd.org> <20140918051834.GD89442@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140918051834.GD89442@FreeBSD.org> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Marcelo Araujo X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2014 06:13:31 -0000 On Thu, Sep 18, 2014 at 09:18:34AM +0400, Gleb Smirnoff wrote: > > On Thu, Sep 18, 2014 at 03:09:35AM +0000, Marcelo Araujo wrote: > M> Author: araujo (ports committer) > M> Date: Thu Sep 18 03:09:34 2014 > M> New Revision: 271735 > M> URL: http://svnweb.freebsd.org/changeset/base/271735 > M> > M> Log: > M> Remove old comment, we already do 802.1q tagging. > > But the comment speaks about 802.1p priority tagging, which > we do not support. So the comment was absolutely correct. > > I'd prefer to see patch reverted. Sorry, I overlooked that. Marcelo has a patch with 802.1p tagging support, I thought the patch was committed. > M> Phabric: D797 > M> Reviewed by: kevlo > M> Approved by: kevlo > M> Sponsored by: QNAP Systems Inc. > M> > M> Modified: > M> head/sys/net/if_vlan.c > M> > M> Modified: head/sys/net/if_vlan.c > M> ============================================================================== > M> --- head/sys/net/if_vlan.c Thu Sep 18 03:02:00 2014 (r271734) > M> +++ head/sys/net/if_vlan.c Thu Sep 18 03:09:34 2014 (r271735) > M> @@ -29,8 +29,7 @@ > M> > M> /* > M> * if_vlan.c - pseudo-device driver for IEEE 802.1Q virtual LANs. > M> - * Might be extended some day to also handle IEEE 802.1p priority > M> - * tagging. This is sort of sneaky in the implementation, since > M> + * This is sort of sneaky in the implementation, since > M> * we need to pretend to be enough of an Ethernet implementation > M> * to make arp work. The way we do this is by telling everyone > M> * that we are an Ethernet, and then catch the packets that > M> > > -- > Totus tuus, Glebius. Kevin