From owner-svn-src-all@FreeBSD.ORG  Tue Mar 20 18:27:05 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3EB21106566C;
	Tue, 20 Mar 2012 18:27:05 +0000 (UTC)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
	by mx1.freebsd.org (Postfix) with ESMTP id AF2848FC08;
	Tue, 20 Mar 2012 18:27:04 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
	by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q2KIR3g7027608;
	Tue, 20 Mar 2012 22:27:03 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q2KIR3jp027607;
	Tue, 20 Mar 2012 22:27:03 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Tue, 20 Mar 2012 22:27:03 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Davide Italiano <davide.italiano@gmail.com>
Message-ID: <20120320182703.GJ30704@FreeBSD.org>
References: <201203162032.q2GKWBRV033715@svn.freebsd.org>
	<20120319194431.GD30704@FreeBSD.org>
	<CACYV=-EmbDNep1rPwF6jfHB2M8JuhLDFvrsvZoBMuVB7kOC1bA@mail.gmail.com>
	<CACYV=-HnKmkcw-p2i9o_VyKGkp6V5yzO0B61uCBOAebg=VHd-A@mail.gmail.com>
	<20120320143611.GH30704@FreeBSD.org>
	<CACYV=-Fpm+3jYZc31DswSzj=ccWdYMnYrDSU5-6K=XwmZY9neA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <CACYV=-Fpm+3jYZc31DswSzj=ccWdYMnYrDSU5-6K=XwmZY9neA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, George Neville-Neil <gnn@FreeBSD.org>,
	svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject: Re: svn commit: r233045 - in head/sys: conf kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Mar 2012 18:27:05 -0000

On Tue, Mar 20, 2012 at 06:00:50PM +0100, Davide Italiano wrote:
D> 2012/3/20 Gleb Smirnoff <glebius@freebsd.org>:
D> > On Mon, Mar 19, 2012 at 09:06:36PM +0100, Davide Italiano wrote:
D> > D> >> These indented ifdefs look like a major violation of style used throughout
D> > D> >> the FreeBSD kernel code. Can you please keep with common style?
D> > D> >>
D> > D> >
D> > D> > Heh,
D> > D> > sorry, also Juli Mallet noticed this, I'm writing a fix for this and
D> > D> > after I'll have approval from my mentor I'll commit.
D> >
D> > Looks okay, apart from additional empty line in NOTES. Isn't single
D> > empty line enough?
D> >
D> > --
D> > Totus tuus, Glebius.
D> 
D> Well, I removed that in my previous commit.
D> It was a mistake.
D> But if you think it's ok to remove that line, I have no objections on this.

Well, I'm not that style(9)-evident person :) I just personally dislike
multiple empty lines, since less code fits on a terminal. So I won't insist
on any choice here.

I just noticed incorrect indentation of ifdefs, and that's all.

-- 
Totus tuus, Glebius.