From owner-freebsd-current Fri Oct 23 00:04:11 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA01264 for freebsd-current-outgoing; Fri, 23 Oct 1998 00:04:11 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from gatekeeper.tsc.tdk.com (gatekeeper.tsc.tdk.com [207.113.159.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA01259 for ; Fri, 23 Oct 1998 00:04:09 -0700 (PDT) (envelope-from gdonl@tsc.tdk.com) Received: from sunrise.gv.tsc.tdk.com (root@sunrise.gv.tsc.tdk.com [192.168.241.191]) by gatekeeper.tsc.tdk.com (8.8.8/8.8.8) with ESMTP id AAA10583; Fri, 23 Oct 1998 00:03:38 -0700 (PDT) (envelope-from gdonl@tsc.tdk.com) Received: from salsa.gv.tsc.tdk.com (salsa.gv.tsc.tdk.com [192.168.241.194]) by sunrise.gv.tsc.tdk.com (8.8.5/8.8.5) with ESMTP id AAA19361; Fri, 23 Oct 1998 00:03:36 -0700 (PDT) Received: (from gdonl@localhost) by salsa.gv.tsc.tdk.com (8.8.5/8.8.5) id AAA20052; Fri, 23 Oct 1998 00:03:35 -0700 (PDT) From: Don Lewis Message-Id: <199810230703.AAA20052@salsa.gv.tsc.tdk.com> Date: Fri, 23 Oct 1998 00:03:34 -0700 In-Reply-To: Kirk McKusick "Re: Soft-Updates aware fsck available." (Oct 22, 10:40pm) X-Mailer: Mail User's Shell (7.2.6 alpha(3) 7/19/95) To: Kirk McKusick , Don Lewis Subject: Re: Soft-Updates aware fsck available. Cc: Julian Elischer , current@FreeBSD.ORG Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Oct 22, 10:40pm, Kirk McKusick wrote: } Subject: Re: Soft-Updates aware fsck available. } If there were a bad block, then `resolved' would not be true } and we would not take this action. I added the resolved variable, } so if we find something fishy in the first or second pass, we } will back off on the aggressive tossing in later passes. If you } remove a large file tree, then some of the subdirectories may not } be completely cleaned out yet, but you still want to nuke them. } So using empty as a criterion is likely to put a bunch of } undesirable stuff in lost+found. Does this seem reasonable? Ok, I feel somewhat better about this now, though autonuking has always bothered me. My big concern is that resolved might be cleared later on, and by then it would be too late ... Something that occurred to me in another thread where I was thinking that unreferenced empty directories should be cleared (the more conservative approach), is that unless you cleared the directories in the correct order, you could end up with links (usually "..") pointing to unallocated inodes if fsck were interrupted while it was cleaning. This would be bad because a subsequent fsck run could stumble over these dangling links and require manual intervention. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message