From owner-freebsd-current Thu Jul 11 15: 8:53 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B4D0837B401; Thu, 11 Jul 2002 15:08:49 -0700 (PDT) Received: from espresso.q9media.com (espresso.q9media.com [65.39.129.122]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B56543E3B; Thu, 11 Jul 2002 15:08:49 -0700 (PDT) (envelope-from mike@espresso.q9media.com) Received: by espresso.q9media.com (Postfix, from userid 1002) id 312AB9C13; Thu, 11 Jul 2002 18:04:42 -0400 (EDT) Date: Thu, 11 Jul 2002 18:04:42 -0400 From: Mike Barcroft To: Bruce Evans Cc: Giorgos Keramidas , current@FreeBSD.ORG Subject: Re: sparc64 tinderbox failure Message-ID: <20020711180442.G89841@espresso.q9media.com> References: <20020711005344.F89841@espresso.q9media.com> <20020712050755.N25069-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020712050755.N25069-100000@gamplex.bde.org>; from bde@zeta.org.au on Fri, Jul 12, 2002 at 05:20:12AM +1000 Organization: The FreeBSD Project Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bruce Evans writes: > On Thu, 11 Jul 2002, Mike Barcroft wrote: > > Comments on the attached, untested patch? > > > Disable fatal warnings during bootstrap, build, and cross tools > > phase of world. > > The setting of NO_WERROR belongs in [BTX]MAKE if anywhere. This is > already done for [BX]MAKE but not for TMAKE. However, I don't like > turning off warnings for any of these. Warnings for these stages may > be even more important and should be less likely than warnings for > building the final world, since it is very important for basic tools > to be correct and for their source to be careful about portabilty > issues. Well, unfortunately I don't think we can depend on older compilers having correct warnings. In PR 40382, it would seem the 4.5 -> HEAD upgrade path is broken because of fatal warnings. A good workaround for that problem might be specifying NO_WERROR for the entire build, in which case -Werror becomes useless anyway. So we might just as well disable early fatal warnings and hope that developers can catch most of the bugs later on in the build. > This also has some style bugs :). Any setting of NO_WERROR turns it on, > so setting it to different spellings of boolean true is just confusing. > It is set correctly for for [BX]MAKE. Oh, that's a much nicer location. :) I think only BMAKE has NO_WERROR defined, not XMAKE. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message