From owner-cvs-src@FreeBSD.ORG Mon May 23 07:33:45 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED48116A41C; Mon, 23 May 2005 07:33:45 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD8CA43D1D; Mon, 23 May 2005 07:33:45 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.3/8.13.3) with ESMTP id j4N7XiVo067589; Mon, 23 May 2005 00:33:44 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.3/8.13.1/Submit) id j4N7XiDi067588; Mon, 23 May 2005 00:33:44 -0700 (PDT) (envelope-from obrien) Date: Mon, 23 May 2005 00:33:44 -0700 From: "David O'Brien" To: Giorgos Keramidas Message-ID: <20050523073344.GA65484@dragon.NUXI.org> References: <200505181330.j4IDU8FV035625@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200505181330.j4IDU8FV035625@repoman.freebsd.org> X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/top commands.c machine.h top.c src/usr.bin/top machine.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2005 07:33:46 -0000 On Wed, May 18, 2005 at 01:30:08PM +0000, Giorgos Keramidas wrote: > keramida 2005-05-18 13:30:08 UTC > > FreeBSD src repository (doc committer) > > Modified files: > contrib/top commands.c machine.h top.c > usr.bin/top machine.c > Log: > Merge the CPU and WCPU columns in a single %6.2f column, add a new 'C' > command that toggles between the two and update the ORDER_PCTCPU() > macro to sort correctly by the visible "cpu" value. Having both CPU and WCPU are a lot more useful than showing the number of threads. Out of the top 70 processes I'm running right now, only _1_ is multi-threaded. How about backing all this out and making your toggle be between #threads and something else -- with the something else being the default thing shown. I still don't know what was wrong with the 'H' display of top(1) which was all about threading. -- -- David (obrien@FreeBSD.org)