Date: Sun, 12 Jan 2003 20:54:03 -0800 From: Terry Lambert <tlambert2@mindspring.com> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: Jake Burkholder <jake@locore.ca>, sparc@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: [PATCH] Re: fpsetmask on sparc64 Message-ID: <3E22466B.2F85F2FF@mindspring.com> References: <20030112031626.GA15783@rot13.obsecurity.org> <20030112015221.G212@locore.ca> <3E212670.41627B9F@mindspring.com> <20030112032908.H212@locore.ca> <3E216911.B7AFC39F@mindspring.com> <20030112134948.I212@locore.ca> <3E21FDAC.1FD36F5C@mindspring.com> <3E2223F4.5554718E@mindspring.com> <20030113034638.GA2310@dhcp01.pn.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Marcel Moolenaar wrote: > On Sun, Jan 12, 2003 at 06:27:00PM -0800, Terry Lambert wrote: > > Therefore, it seems to me, that the correct place to put them is in > > the <machine/floatingpoint.h> header (the other alternative was the > > <machine/ieeefp.h> header; this seemed wrong to me, but I'm willing > > to reroll the patch, if there's a lot of disagreement over this point). > > I would like to see it in <machine/ieeefp.h>: I didn't put it there because that's not where the i386 is getting its version of fpsetmask(), et al. As I said, I'd be happy to reroll the patch, and be overruled. Should I move the i386 inline function and #define's from the machine/floatingpoint.h to the machine/ieeefp.h, as well? It seems to me that all the symbols should come from that place, on all architectures, no matter what place it ends up being. > The synopsis section of our manpage clearly states the inclusion > of <ieeefp.h>. That header file includes a machine dependent > counterpart <machine/ieeefp.h>. On alpha, ia64 and sparc64 > <machine/floatingpoint.h> is empty with the exception of the > inclusion of <machine/ieeefp.h>. Actually, on SPARC and i386, it puts _FLOATINGPOINT_H_ into scope, too, while on IA64 and Alpha, it doesn't (which is broken, for the #include #ifndef/#define ... /#endif style). > Hence, I would like to see the prototypes and/or implementation > in <machine/ieeefp.h>. Since on i386 <machine/floatingpoint.h> > also includes <machine/ieeefp.h>, we should be able to move > the implementation on i386 to <machine/ieeefp.h> as well. If > possible, I'd like to see <machine/floatingpoint.h> retired > unless there's a compelling reason to keep it... Well, that answers my question from above: "yes". 8-). -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-sparc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3E22466B.2F85F2FF>