From owner-cvs-all@FreeBSD.ORG Wed Jun 21 10:20:13 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FDDA16A474; Wed, 21 Jun 2006 10:20:13 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E06743D67; Wed, 21 Jun 2006 10:20:11 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 7FD021FF9A8; Wed, 21 Jun 2006 12:20:09 +0200 (CEST) Received: by transport.cksoft.de (Postfix, from userid 66) id 99E321FF9A7; Wed, 21 Jun 2006 12:20:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 3D2654448D6; Wed, 21 Jun 2006 10:16:30 +0000 (UTC) Date: Wed, 21 Jun 2006 10:16:30 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Max Laier In-Reply-To: <200606211113.31621.max@love2party.net> Message-ID: <20060621100956.I60374@maildrop.int.zabbadoz.net> References: <200606210602.k5L62Zor029243@repoman.freebsd.org> <20060621120212.D93005@mp2.macomnet.net> <200606211113.31621.max@love2party.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de Cc: cvs-src@freebsd.org, Maxim Konovalov , Gleb Smirnoff , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net if.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2006 10:20:13 -0000 On Wed, 21 Jun 2006, Max Laier wrote: > On Wednesday 21 June 2006 10:06, Maxim Konovalov wrote: >> On Wed, 21 Jun 2006, 06:02-0000, Gleb Smirnoff wrote: >>> glebius 2006-06-21 06:02:35 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/net if.c >>> Log: >>> - First initialize ifnet, and then insert it into global >>> list. >>> - First remove from global list, then start destroying. >>> >>> PR: kern/97679 >>> Submitted by: Alex Lyashkov >>> Reviewed by: rwatson, brooks >> >> FWIW, even with Yar's recent commit to if_vlan.c it still panics. I >> told Alex about that. A testcase below. Run it for several minutes. > > Yes, we simply keep too many implicit references to ifnets. The real sequence > for interface destruction should be: I had been looking at that code somewhen last year I think trying to clean up some ordering along the af/domain logic and my conclusion was that in netinet6/* some bad things are done that by that time prevented me from further working on this to get it anywhere w/o a panic. Welcome to the club ;) -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT