From owner-freebsd-current Wed Nov 27 13:42:53 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2317437B401 for ; Wed, 27 Nov 2002 13:42:52 -0800 (PST) Received: from gull.mail.pas.earthlink.net (gull.mail.pas.earthlink.net [207.217.120.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id C5FCF43E9C for ; Wed, 27 Nov 2002 13:42:51 -0800 (PST) (envelope-from tlambert2@mindspring.com) Received: from pool0147.cvx21-bradley.dialup.earthlink.net ([209.179.192.147] helo=mindspring.com) by gull.mail.pas.earthlink.net with esmtp (Exim 3.33 #1) id 18H9xI-0004uF-00; Wed, 27 Nov 2002 13:42:49 -0800 Message-ID: <3DE53BEE.A71BCCE1@mindspring.com> Date: Wed, 27 Nov 2002 13:41:02 -0800 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Garance A Drosihn Cc: "David W. Chapman Jr." , current@FreeBSD.ORG Subject: Re: pw_user.c change for samba References: <20021127192126.GA31706@leviathan.inethouston.net> <3DE52B70.44402B98@mindspring.com> <20021127203401.GA35573@leviathan.inethouston.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Garance A Drosihn wrote: > >the machine account always ends with a $ > > > >So it would only have to be for the account name > > I think I'd prefer a somewhat more involved change, one which > allowed $ only for account-name, and only as the last character. > That seems like a good idea to me. > > But then, I'm not volunteering to write it... :-) My change doesn't allow it only for the last, but it does restrict it to the login name. I notice that pw.h exports the code. If somone is using the function from outside, that's probably something that needs to be considered. I've changed the prototype, so that it will at least complain on compilation, if someone is using the code that way. I think the "$" on the end worked because of the "dangling $" handling in the shell they they happened to be using; the original example namess are still broken for some shells, with no back-quoting. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message