From owner-svn-src-all@FreeBSD.ORG  Wed Nov 19 14:30:03 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4AA3EAD7
 for <svn-src-all@freebsd.org>; Wed, 19 Nov 2014 14:30:03 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id C5A25E28
 for <svn-src-all@freebsd.org>; Wed, 19 Nov 2014 14:30:01 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id sAJETt01044534
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 19 Nov 2014 17:29:55 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id sAJETtK5044533;
 Wed, 19 Nov 2014 17:29:55 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 19 Nov 2014 17:29:55 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Anton Yuzhaninov <citrin@citrin.ru>
Subject: Re: svn commit: r274710 - head/sbin/ifconfig
Message-ID: <20141119142955.GF43381@glebius.int.ru>
References: <201411191357.sAJDvexm004236@svn.freebsd.org>
 <546CA502.4020008@citrin.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <546CA502.4020008@citrin.ru>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-all@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2014 14:30:03 -0000

On Wed, Nov 19, 2014 at 05:11:14PM +0300, Anton Yuzhaninov wrote:
A> On 11/19/14 16:57, Mark Felder wrote:
A> > New Revision: 274710
A> > URL: https://svnweb.freebsd.org/changeset/base/274710
A> >
A> > Log:
A> >    Expose groups by default in ifconfig output. This was never hidden by
A> >    OpenBSD; unsure why we chose to do so. As groups are a requirement for
A> >    pf, exposing them by default will make our pf implementation less
A> >    confusing.
A> ...
A> >
A> > Modified: head/sbin/ifconfig/ifgroup.c
A> > ==============================================================================
A> > --- head/sbin/ifconfig/ifgroup.c	Wed Nov 19 13:31:08 2014	(r274709)
A> > +++ head/sbin/ifconfig/ifgroup.c	Wed Nov 19 13:57:39 2014	(r274710)
A> > @@ -86,9 +86,6 @@ getifgroups(int s)
A> >   	struct ifgroupreq	 ifgr;
A> >   	struct ifg_req		*ifg;
A> >
A> > -	if (!verbose)
A> > -		return;
A> 
A> Please return groups output under verbose flag.
A> 
A> pf is used not by all.
A> 
A> And more longer ifconfig output is unhandy. Especially on hosts with many 
A> interfaces.
A> 
A> Better to document ifconfig -v in pf.conf(5)

Better to document it in ifconfig(8). Actually ifgroups are not a part
of pf(5). And commit has nothing to do with "our pf implementation being
confusing".

P.S. I was pretty sure that users would not like changing defaults for ifconfig.

-- 
Totus tuus, Glebius.