From owner-svn-src-head@FreeBSD.ORG Fri Sep 14 12:03:16 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4CF34106568E; Fri, 14 Sep 2012 12:03:16 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 50BE18FC15; Fri, 14 Sep 2012 12:03:14 +0000 (UTC) Received: by lbbgg13 with SMTP id gg13so3273705lbb.13 for ; Fri, 14 Sep 2012 05:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=iRR8Wez2N7axnVjIimmZKzWygRTtvok6lFI8MPjbpfs=; b=BmQvWTeE/Iyko9Ygz1V9amX48riIJ5klhZFFbPR06DYt9x4mC86xNVq4aDR6KYIztH pZI9EiIdGvzmDGAaMLo2JYEK0lxH4a55snn1VTlgjgzsQrSpvABPKZMJrQR5WlI68+yR EZQpafGZ2CNIg+0qvld9Zcw9SOZmYtGTioXJgJ6eNn2x+Ve459Q7tvVMuiLmP2yC4Jzu wbaYDb1BrhkWGy2AmQ43lGI5BoOpDQWy2QmAbSL1skBo9wN/38tyy3lOI8qHp5IBIs/P OpoJwLkhj6iG6nQoRjGk7QLGGh6GZna0gofU/NNwI0uDaB6qQq/2LVK2oakpVxDXhhHa Xg7g== MIME-Version: 1.0 Received: by 10.152.131.37 with SMTP id oj5mr2230047lab.14.1347624193612; Fri, 14 Sep 2012 05:03:13 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.102.39 with HTTP; Fri, 14 Sep 2012 05:03:13 -0700 (PDT) In-Reply-To: <20120914042031.GZ37286@deviant.kiev.zoral.com.ua> References: <201209132226.q8DMQMFC088169@svn.freebsd.org> <20120914042031.GZ37286@deviant.kiev.zoral.com.ua> Date: Fri, 14 Sep 2012 13:03:13 +0100 X-Google-Sender-Auth: 5r9lM6r6fwgTrBt4OZLVNorsUJI Message-ID: From: Attilio Rao To: Konstantin Belousov Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240475 - in head/sys: dev/hwpmc kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2012 12:03:16 -0000 On 9/14/12, Konstantin Belousov wrote: > On Thu, Sep 13, 2012 at 10:26:22PM +0000, Attilio Rao wrote: >> Author: attilio >> Date: Thu Sep 13 22:26:22 2012 >> New Revision: 240475 >> URL: http://svn.freebsd.org/changeset/base/240475 >> >> Log: >> Remove all the checks on curthread != NULL with the exception of some >> MD >> trap checks (eg. printtrap()). >> >> Generally this check is not needed anymore, as there is not a >> legitimate >> case where curthread != NULL, after pcpu 0 area has been properly >> initialized. > I do not disagree with the patch, but I do with this statement. > During the AP startup, there is indeed a window while curthread is NULL. > Unfortunately, trying to panic there is worse then not panic. Yes and why do you disagree then? That is what I wanted to say -- before pcpu->curthread is initialized you can get curthread == NULL. Attilio -- Peace can only be achieved by understanding - A. Einstein