From owner-freebsd-bugs@FreeBSD.ORG Thu Oct 28 23:10:23 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AAB201065670; Thu, 28 Oct 2010 23:10:23 +0000 (UTC) (envelope-from arundel@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9AE948FC0C; Thu, 28 Oct 2010 23:10:23 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o9SNAN0H024657; Thu, 28 Oct 2010 23:10:23 GMT (envelope-from arundel@freefall.freebsd.org) Received: (from arundel@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o9SNAN0N024623; Thu, 28 Oct 2010 23:10:23 GMT (envelope-from arundel) Date: Thu, 28 Oct 2010 23:10:23 GMT Message-Id: <201010282310.o9SNAN0N024623@freefall.freebsd.org> To: rui@ruilopes.com, arundel@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: arundel@FreeBSD.org Cc: Subject: Re: bin/57088: [cam] [patch] for a possible fd leak in libcam.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2010 23:10:23 -0000 Synopsis: [cam] [patch] for a possible fd leak in libcam.c State-Changed-From-To: suspended->open State-Changed-By: arundel State-Changed-When: Thu Oct 28 22:27:36 UTC 2010 State-Changed-Why: The fd leak was fixed in r158171. The possible buffer overruns however still exist. I'll submit a patch shortly (against HEAD), which will turn all sprintf(3) calls in connection with cam_errbuf to snprintf(3) calls. Although this might not be necessary in all cases, it should however improve overall robustness of camlib.c. Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: arundel Responsible-Changed-When: Thu Oct 28 22:27:36 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=57088