From owner-freebsd-hackers Fri Jan 31 06:16:49 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA24037 for hackers-outgoing; Fri, 31 Jan 1997 06:16:49 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id GAA24031; Fri, 31 Jan 1997 06:16:41 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.3/8.6.9) id BAA19407; Sat, 1 Feb 1997 01:11:34 +1100 Date: Sat, 1 Feb 1997 01:11:34 +1100 From: Bruce Evans Message-Id: <199701311411.BAA19407@godzilla.zeta.org.au> To: freebsd-hackers@freefall.freebsd.org, mpp@freefall.freebsd.org Subject: Re: grp.h Sender: owner-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >Shouldn't the declaration in grp.h read: > > gid_t gr_gid; > >instead of: > > int gr_gid; > >like it currently does? It should at least have the same type. Avoiding grp_t has the advantage that need not depend on . However, already uses gid_t elsewhere. This has been on my list of things to fix for several years. I haven't had time to check for dependenices on sign extension bugs. >It also looks like pwd.h also declares the uid and gid as ints >instead of using the typedefs. Similarly, except already pollutes the namespace by including . Bruce