From owner-freebsd-bugs@FreeBSD.ORG  Thu Jan 22 07:00:15 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E28781065670
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 22 Jan 2009 07:00:15 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D0EC98FC12
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 22 Jan 2009 07:00:15 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n0M70FfB054933
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 22 Jan 2009 07:00:15 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n0M70FK8054931;
	Thu, 22 Jan 2009 07:00:15 GMT (envelope-from gnats)
Date: Thu, 22 Jan 2009 07:00:15 GMT
Message-Id: <200901220700.n0M70FK8054931@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Giorgos Keramidas <keramida@freebsd.org>
Cc: 
Subject: Re: bin/130857: /bin/dd if=/dev/acd0 returned error "invalid
	parameter"
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Giorgos Keramidas <keramida@freebsd.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jan 2009 07:00:16 -0000

The following reply was made to PR bin/130857; it has been noted by GNATS.

From: Giorgos Keramidas <keramida@freebsd.org>
To: Tri Brotoharsono <tbh@ittelkom.ac.id>
Cc: bug-followup@freebsd.org
Subject: Re: bin/130857: /bin/dd if=/dev/acd0 returned error "invalid parameter"
Date: Thu, 22 Jan 2009 08:37:52 +0200

 On Thu, 22 Jan 2009 06:00:10 GMT, Tri Brotoharsono <tbh@ittelkom.ac.id> wrote:
 > Invoking command /bin/dd with input file CDROM device file returned invalid parameter
 >
 > Example:
 > # dd if=/dev/acd0 of=dd.iso
 > dd: /dev/acd0: Invalid argument
 > 0+0 records in
 > 0+0 records out
 > 0 bytes transferred in 0.000080 secs (0 bytes/sec)
 > #
 
 > --- dd.c	2009-01-22 12:27:26.000000000 +0700
 > +++ dd.c.orig	2009-01-22 12:27:17.000000000 +0700
 > @@ -121,7 +121,7 @@
 >  		in.name = "stdin";
 >  		in.fd = STDIN_FILENO;
 >  	} else {
 > -		in.fd = open(in.name, O_RDONLY);
 > +		in.fd = open(in.name, O_RDONLY, 0);
 >  		if (in.fd == -1)
 >  			err(1, "%s", in.name);
 >  	}
 
 Are you sure this fixes the problem?  I seem to recall audio CD-ROMs
 needs a different block size in dd.  Maybe this is why the original
 invocation failed?