Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Oct 1995 18:55:01 +0800 (WST)
From:      Peter Wemm <peter@jhome.DIALix.COM>
To:        David Greenman <davidg@freefall.freebsd.org>
Cc:        CVS-commiters@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org
Subject:   Re: cvs commit: src/usr.sbin/config mkmakefile.c
Message-ID:  <Pine.BSF.3.91.951023185233.5332N-100000@jhome.DIALix.COM>
In-Reply-To: <199510231029.DAA02147@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Oct 1995, David Greenman wrote:
> 
> davidg      95/10/23 03:29:17
> 
>   Modified:    usr.sbin/config  mkmakefile.c
>   Log:
>   Don't pre-processor define 'ident'. This has subtle consequences for people
>   who don't carefully consider their choice for the machine name. The same
>   functionality can still be had with an "option", so nothing is lost.

I saw a couple of
#ifdef GENERIC /* compiling for generic kernel */
....
#endif
around the place some time ago.  Are these gone too?

If this functionality is needed, perhaps it'd be better to change it to 
CONFIG_<ident> instead?  ie: #ifdef CONFIG_GENERIC instead?

-Peter




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.91.951023185233.5332N-100000>