Date: Sat, 10 Mar 2012 13:11:49 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Martin Wilke <miwi@FreeBSD.org> Cc: Radim Kolar <hsn@sendmail.cz>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/databases/cassandra Makefile distinfo pkg-plist ports/databases/cassandra/files cassandra.in repaircluster.in Message-ID: <4F5BC395.7080909@FreeBSD.org> In-Reply-To: <201203101712.q2AHCA2E020027@repoman.freebsd.org> References: <201203101712.q2AHCA2E020027@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Overall the rc.d script looks good. Just 2 suggestions that could be rolled into the next update. The empty assignment for cassandra_vmargs is bad, and should instead be in comments ... see http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html. The exported values should probably be in a start_precmd, but I have a vague recollection that this caused "issues" for java stuff, so please try it, and if it doesn't work, no problem. hth, Doug On 3/10/2012 9:12 AM, Martin Wilke wrote: > miwi 2012-03-10 17:12:10 UTC > > FreeBSD ports repository > > Modified files: > databases/cassandra Makefile distinfo pkg-plist > databases/cassandra/files cassandra.in repaircluster.in > Log: > - Update to 1.0.8 > - extend repaircluster command to take optional keyspace name argument > - improve stop procedure in rc.d script > > PR: 165816 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=165816 > Submitted by: Radim Kolar <hsn@sendmail.cz> > Feature safe: yes > > Revision Changes Path > 1.21 +1 -1 ports/databases/cassandra/Makefile > 1.17 +2 -2 ports/databases/cassandra/distinfo > 1.7 +2 -5 ports/databases/cassandra/files/cassandra.in > 1.3 +3 -3 ports/databases/cassandra/files/repaircluster.in > 1.18 +5 -3 ports/databases/cassandra/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/cassandra/Makefile.diff?&r1=1.20&r2=1.21&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/cassandra/distinfo.diff?&r1=1.16&r2=1.17&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/cassandra/files/cassandra.in.diff?&r1=1.6&r2=1.7&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/cassandra/files/repaircluster.in.diff?&r1=1.2&r2=1.3&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/cassandra/pkg-plist.diff?&r1=1.17&r2=1.18&f=u > -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F5BC395.7080909>