From owner-svn-src-head@freebsd.org Sun Oct 25 16:55:22 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F2B22452DEB for ; Sun, 25 Oct 2020 16:55:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CK3xQ1Tjvz4HWh for ; Sun, 25 Oct 2020 16:55:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72a.google.com with SMTP id z6so6253732qkz.4 for ; Sun, 25 Oct 2020 09:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mTCfmNXXkaH4nufEdBISvI8aVyplNVjyzinFIMi6Mdg=; b=EhYX2GkLR9aVRMQ8qLYkQAvtDBpuGINeGMcT7z5ipDzkAa6h90pNNyZFpjFy2P78fi zbUVHNkRnyxwHERUVoddeeGC9tYNxpBc3SRFJVZ6SCrUp+CSHqnBPy60r5bxh6Z+oiQQ bC/OK7tkYiE1IMBN2GyUxVdSrs0C5ro5tynyh9lGv2IGuOlvfx0tekABp98R9PFrn+dM zu9wEwjvsuanTefxxXxyG3jL5xPxcI8OOgzHBQBYH7/C3gt8cLqWNRS6LGkYE5MP6Su6 1oTyeJdmRKxNXXEj52nOwMpSU/K+rA+P+4gr78H3Me8D1ocu2wvDmutwIoBDnOInJIgd 7brQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mTCfmNXXkaH4nufEdBISvI8aVyplNVjyzinFIMi6Mdg=; b=pqOK4d84VY7PEu3muSlVfmrylyZrNsaMVpFsAxRmT3Gwb7pfqm9juzzou9kFioqf+d G3hZoD6G9nRJ0WuafJN/Y9f8QdoZpFvYddDyjEI105YAgiX8baDqBj2zC34sz3Oe5z9M wiqu/rLMQQ9t070JgTiauI2v45oBCYaztHeK7F46mdtvbDWPWzwZn6amb3IaA1J0SXqh OuCg/FCbAC7+b11vus5dBTtg1Q1MALsVLdhcONJwMSiw5HAe2kzr6/bLMT9oAY9yPOaL CvVYezrEGqj8cyEuPeN4ywEX2xDRSsI/lf7y+0oMMOpN9Y/9aw1NGxkL1WWdCqdKkR7r 3lBA== X-Gm-Message-State: AOAM530MJ/glKFvgUdPn5ytOLSOp0UrERF1XSN7ZL2qNr/f7YSUGIpw7 BN0jK8MZxch++kaE51ZoqeP3OTUp48fZrVYombbBRw== X-Google-Smtp-Source: ABdhPJwvd8Ek5CrXkBcC2S07G0PaMWpqUBkoyWY2ZSi18GZoA69f6m/8ah3qbqBQDKK/2vN3SUDVCcZTmc3XHA4CoFk= X-Received: by 2002:a37:5ca:: with SMTP id 193mr12584417qkf.44.1603644920870; Sun, 25 Oct 2020 09:55:20 -0700 (PDT) MIME-Version: 1.0 References: <202010250346.09P3kTVH076745@gndrsh.dnsmgr.net> In-Reply-To: From: Warner Losh Date: Sun, 25 Oct 2020 10:55:08 -0600 Message-ID: Subject: Re: svn commit: r366962 - in head: include usr.bin/calendar To: Kyle Evans Cc: Stefan Esser , "Rodney W. Grimes" , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4CK3xQ1Tjvz4HWh X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=EhYX2GkL; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::72a) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.56 / 15.00]; ARC_NA(0.00)[]; MAILMAN_DEST(0.00)[svn-src-head]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-0.92)[-0.919]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.64)[-0.640]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::72a:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Oct 2020 16:55:23 -0000 On Sun, Oct 25, 2020, 9:04 AM Kyle Evans wrote: > On Sun, Oct 25, 2020 at 5:21 AM Stefan Esser wrote: > > > > Am 25.10.20 um 04:46 schrieb Rodney W. Grimes: > > >> On Sat, Oct 24, 2020 at 8:51 PM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > >> wrote: > > >>>> +#define _PATH_LOCALBASE "/usr/local" > > >>>> + > > >>> > > >>> Something feels very wrong about this becoming a defined path in > base, > > >>> it is further dependence on /usr/local which in the early days we > spent > > >>> a great deal of time removing. > > >>> > > >>> I believe the whole ports system allows this to be something other > > >>> than /usr/local. Package should also allow it to be some other > place. > > >>> > > >> > > >> This removes a couple of instances of /usr/local being hardcoded and > > >> replaces with a define, so net it's better. > > > > > > No, its net worse as it now creates a define that is highly likely > > > to propogate adding additional dependencies on this value. > > > > > >> > > >> It could be even better, but this is slightly better than it was > before. > > > > > > I disagree, as it is now easier for additional contamination of > > > the base system. > > > > There already are places that hard-code /usr/local, and I do agree > > that this is architecturally bad, if you want to keep the base system > > and ports as independent from each other as possible. > > > > But I do disagree that this was worse than before, and I'd even consider > > replacing other verbatim occurrences of /usr/local with _PATH_LOCALBASE > > in our sources (but not introduce new references to LOCALBASE in base). > > > > This would simplify a grep for such source files, for example, and also > > to build base for systems with modified LOCALBASE. > > > > The following C header files in base (ignoring contrib) contain the > > string /usr/local: > > > > ... > > sys/contrib/openzfs/include/sys/lua/luaconf.h (FreeBSD specific?) > > ... > > I see that you've excluded sys/contrib from the initial review, but I > would not bother with luaconf.h in particular. These definitions just > come from a stock Lua 5.2 and are not used in a ZFS context, they've > ripped out loadlib and anything else that could try. > As an aside: I looked at using this Lua for the boot loader, but quickly found that it was no good for that purpose due to changes like that. And it was too far hacked from 5.2 to try to update easily... Warner Thanks, > > Kyle Evans >