From owner-svn-src-head@FreeBSD.ORG Sat Jul 27 20:48:04 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A584E308 for ; Sat, 27 Jul 2013 20:48:04 +0000 (UTC) (envelope-from andrey@zonov.org) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 762C12462 for ; Sat, 27 Jul 2013 20:48:04 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id ro12so38949pbb.27 for ; Sat, 27 Jul 2013 13:47:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :x-gm-message-state; bh=XPUQG9xsVlmb7bcoASZZJGKZESKuJdnuv2+4Gvu1S1E=; b=eoqRDMAdlG5rMxEt4uSVB+0dAeogNRy2xHXh+SbNPZI1jEteUXjddy9bLQ9FE5rUQ3 4oSsfcCtsI3x9DDH4ztm/qTBpep8CLBi1CBfRdJQGaPDqzppFP5AXS6TRLq+KjjPWHAc EdXh8Pqd/K98oxk5/ZJ8JBbIVv+kftfw4RaI1OSE+qd0T8Fbb8MF9JYs9EbF8aFA+qn3 cXPmbJWHuVRK9RUQO6z34QwM2O3EiXKhB9iCGw2Ha6bStkN8pUVwiYARW11UISd6De7b 4CeZvyAVeD6l0x87/4DMhH6JsK5iNs62v8Maf8X9AHhlSN1SmqQ/kvx6+ZfKKw7QWgJ0 5C6Q== X-Received: by 10.68.218.199 with SMTP id pi7mr60324737pbc.19.1374958078693; Sat, 27 Jul 2013 13:47:58 -0700 (PDT) Received: from zont-osx.local (c-50-136-243-235.hsd1.ca.comcast.net. [50.136.243.235]) by mx.google.com with ESMTPSA id t9sm9748276pba.46.2013.07.27.13.47.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 27 Jul 2013 13:47:57 -0700 (PDT) Sender: Andrey Zonov Message-ID: <51F431F8.1040803@FreeBSD.org> Date: Sat, 27 Jul 2013 13:47:52 -0700 From: Andrey Zonov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Bruce Evans Subject: Re: svn commit: r253662 - in head: lib/libc/gen sys/vm tools/tools/sysdoc References: <201307260200.r6Q207cB015223@svn.freebsd.org> <20130726150949.GC14175@stack.nl> <51F2E970.3070303@FreeBSD.org> <20130727170845.E872@besplex.bde.org> In-Reply-To: <20130727170845.E872@besplex.bde.org> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2BWDOWUBELCWUQNFBHHBD" X-Gm-Message-State: ALoCoQkWZhcEx+cqK6Rl2jH0Fdi4j++kKukxJueuS0riaeGsteEn8AZeswQw9AxzNKLMESi1uZ0p Cc: Juli Mallett , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Jilles Tjoelker X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jul 2013 20:48:04 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2BWDOWUBELCWUQNFBHHBD Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 7/27/13 12:47 AM, Bruce Evans wrote: > On Fri, 26 Jul 2013, Juli Mallett wrote: >=20 >> On Fri, Jul 26, 2013 at 2:26 PM, Andrey Zonov wrote= : >> >>> On 7/26/13 8:09 AM, Jilles Tjoelker wrote: >>>> As noted in mail from Bruce Evans, please preserve the ABI of >>>> VM_SWAPPING_ENABLED here. >>> >>> I don't think it's a big problem. Internally we don't use it. Good >>> code uses sysctlbyname() instead of sysctl(). It doesn't seem to me >>> this is very popular sysctl. It's also CURRENT without MFC. >> >> That doesn't seem like a great argument. >> >> Why should we break the ABI for bad code that used that sysctl and all= >> following? It seems pretty trivial to preserve, and no-cost. Also, t= he >> fact that it's in current misses the point completely: it breaks ABI w= ith >> older binaries, namely older binaries running on -CURRENT. And not ju= st >> for that field. >=20 > Especially since the main reason numbered sysctls exist is to support o= ld > binaries (and sources) that use them. >=20 Does it look OK? diff --git a/sys/vm/vm_param.h b/sys/vm/vm_param.h index 44306be..0323473 100644 --- a/sys/vm/vm_param.h +++ b/sys/vm/vm_param.h @@ -82,8 +82,9 @@ #define VM_V_CACHE_MIN 7 /* cnt.v_cache_min */ #define VM_V_CACHE_MAX 8 /* cnt.v_cache_max */ #define VM_V_PAGEOUT_FREE_MIN 9 /* cnt.v_pageout_free_min */ -#define VM_SWAPPING_ENABLED 10 /* swapping enabled */ -#define VM_MAXID 11 /* number of valid vm ids= */ +/*#define VM_PAGEOUT_ALGORITHM 10 pageout algorithm */ +#define VM_SWAPPING_ENABLED 11 /* swapping enabled */ +#define VM_MAXID 12 /* number of valid vm ids= */ #define CTL_VM_NAMES { \ { 0, 0 }, \ @@ -96,6 +97,7 @@ { "v_cache_min", CTLTYPE_UINT }, \ { "v_cache_max", CTLTYPE_UINT }, \ { "v_pageout_free_min", CTLTYPE_UINT}, \ + { "obsolete_pageout_algorithm", CTLTYPE_INT}, \ { "swap_enabled", CTLTYPE_INT},\ } --=20 Andrey Zonov ------enig2BWDOWUBELCWUQNFBHHBD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org iQEcBAEBAgAGBQJR9DH7AAoJEBWLemxX/CvTTl4H/Rbjk4vlXRxR2t/+z1Kcx4vS 5DpoM6DRfC3jZi3qfo2TxT600+5Ekyabhgpe6Gp3VM4TZVo0trC7lphPZ+I/0cv4 FWy9ElytnJIJYIlZcTOYXTLbD92itdkFKF2AqZL8Rttrt048CFy0XKYuHA9EIKSz Tj1B+5EfG+6ymdmC4JcPqfTAZxuO20jOIUcTx/WCgne7l21bbloC+/AJ+kyAPfQF HJAYktT134bpnP6lxigk67vTBALTskv08ucPXpKdVnxUpFy79riauweKKmNxibA2 TqczSDSULkSqC1ytTKCAWwhl5ZP9UsCO++RqSDag/rw8WpZPiOEm+h5Ykt9QNYE= =Cdzu -----END PGP SIGNATURE----- ------enig2BWDOWUBELCWUQNFBHHBD--