Date: Thu, 7 Aug 2003 04:00:31 -0700 (PDT) From: Lefteris Chatzibarbas <lefcha@hellug.gr> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/55320: Update port: mail/imapfilter Message-ID: <200308071100.h77B0V2G051943@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/55320; it has been noted by GNATS. From: Lefteris Chatzibarbas <lefcha@hellug.gr> To: Kang Liu <liukang@bjpu.edu.cn> Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: ports/55320: Update port: mail/imapfilter Date: Thu, 7 Aug 2003 13:50:45 +0300 On Thu, Aug 07, 2003 at 03:05:17PM +0800, Kang Liu wrote: > I think this patch can fix build problem on 4.x :) > > --- /dev/null Thu Aug 7 15:03:19 2003 > +++ files/patch-socket.c Thu Aug 7 15:02:42 2003 > @@ -0,0 +1,12 @@ > +--- socket.c.orig Thu Aug 7 14:42:52 2003 > ++++ socket.c Thu Aug 7 15:00:17 2003 > +@@ -7,6 +7,9 @@ > + #include <netinet/in.h> > + #include <netdb.h> > + #include <fcntl.h> > ++#if __FreeBSD_version < 500000 > ++#include <sys/time.h> > ++#endif > + > + #include "config.h" > + #include "imapfilter.h" Yes, according to POSIX (IEEE Std 1003.1-2001) the timeval structure should be defined in <sys/time.h> and <sys/select.h>, but unfortunately I didn't include any of these headers in socket.c. I think there is no need to check the version of the system; the aforementioned headers should have been included in the first place. Anyway, this will be corrected in the next release (so the patch won't be needed). Thanks for your time, finding the cause of the problem.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200308071100.h77B0V2G051943>