From nobody Wed Dec 6 20:04:10 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SlpJY1Dffz52tLx; Wed, 6 Dec 2023 20:04:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SlpJY0fq7z3Mjm; Wed, 6 Dec 2023 20:04:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701893053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M3l/VsmIJQRbS0fr9Poow9BDpS1//fulTsgMBob7XEE=; b=js3eJy/gEr8qnBqhlDyCr2zX6UUhWzC3NpKz1QlZOrdQ9/f6EOEi2l2spRihLOjbltEcIv G8YyUSczsHep3RHlNSjhpkW1N44MJczeQ45jjdg9hFVYZQoSoXQ5J5YtZowvWRqs8U3ca+ VCVH4m0pHKNTKtodAot0KTA4jNHZBYSgTWU/E2UcjRRh9uaI9rphvCVRoCTmFCxCV36XlY vblwpOrCToRa/MTYb/V/XL1tRBqz7wadl9+DC5MGN2agNEoiUxNuB34rnnhmP2opplLuul Q6SRMXSeG10Luh1GJfP2iUlelU5vH/aFfR3A6ILDfNQr0a5YRuU5cq98SmaaZw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701893053; a=rsa-sha256; cv=none; b=Gd84H5XanL8xG+pSS66KB0UUkpKbEUlm0ARJJ5bJtNiaCZMzL+T+ZwdK7iHykd3QcxoSEF 2sEITSdPMrMcpgBoDvERqtbQYx2eQ9XUuFLnC7obdJt/cRIoOhSrrljmln/gc/BMv1iIEq XwbEKc7fBqEJZVMN3OACuH7UH1/T4dKpL66G9sWQJ3GGkWp7Lccb4LYRAz3rk16Cwcs4qY /vt6FPwQNFYvgGY6h3cOELYrPVHaBwoaSckU9H2I7ukBlhA7VAgEvwX9ULAOBWxnHGZEfq gcVh/v2i82CsVax0/Jx+9XxloYiqdbuTTvQ+IHcn6vG2AL3D9DEcj46NK2bEpg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701893053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M3l/VsmIJQRbS0fr9Poow9BDpS1//fulTsgMBob7XEE=; b=P6+Rn8fZn1/cymw7VFmCFLbpkFgp1KeLPiXc+Mq9nyZPcvu7ZYF8c7sUREGZ0yL3B2OFSD +EbcNJNit0mi3RFfPVZ3gMA6fiQ2qJjbNqJ/UOzmexbDmNXT0C3ZFNjRy3EL9/vRXg49N1 aZNzUaTGdOrBB3VjSZbicdDhyaxDCni9wOSJn6T7aABjs5HKm7CI3iI8txi5cWBm4CVw7C ghwoxEOPiJQ4uKh9+8QBoWsjY6TN6VFd/N4FSAp8oAZamaOPUE+PcKw09vxQgQlvMGx0dq bfourgX7zvcG22dw4DBuMQlOShJ3PGi5lVRnohjm8r9Lo+Ogwuoj5Vy5+T7VeA== Received: from [IPV6:2601:648:8384:fd00:8d37:e6e8:747c:72de] (unknown [IPv6:2601:648:8384:fd00:8d37:e6e8:747c:72de]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SlpJX3rhXz1GCb; Wed, 6 Dec 2023 20:04:12 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Wed, 6 Dec 2023 12:04:10 -0800 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 773c13c686e4 - main - kldxref: skip .pkgsave files Content-Language: en-US To: Warner Losh , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202302251737.31PHb2R8072300@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202302251737.31PHb2R8072300@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/25/23 9:37 AM, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=773c13c686e4b6ae9dbbc150b342b82c3f47d73a > > commit 773c13c686e4b6ae9dbbc150b342b82c3f47d73a > Author: Mina Galić > AuthorDate: 2023-02-25 17:31:58 +0000 > Commit: Warner Losh > CommitDate: 2023-02-25 17:35:43 +0000 > > kldxref: skip .pkgsave files > > This should help people transitioning from traditional setups to pkgbase > experience a lot less friction. > > We do this by skipping all files containing two dots. > > Reviewed by: imp > Pull Request: https://github.com/freebsd/freebsd-src/pull/661 > Differential Revision: https://reviews.freebsd.org/D27959 This restriction is too broad and omits all of the modern wifi firmware klds from linker.hints, e.g. /boot/kernel/iwlwifi-3160-17.ucode.ko /boot/kernel/iwlwifi-3168-29.ucode.ko /boot/kernel/iwlwifi-7260-17.ucode.ko /boot/kernel/iwlwifi-7265-17.ucode.ko /boot/kernel/iwlwifi-7265D-29.ucode.ko /boot/kernel/iwlwifi-8000C-36.ucode.ko /boot/kernel/iwlwifi-8265-36.ucode.ko /boot/kernel/iwlwifi-9000-pu-b0-jf-b0-46.ucode.ko /boot/kernel/iwlwifi-9260-th-b0-jf-b0-46.ucode.ko /boot/kernel/iwlwifi-Qu-b0-hr-b0-77.ucode.ko /boot/kernel/iwlwifi-Qu-b0-jf-b0-77.ucode.ko /boot/kernel/iwlwifi-Qu-c0-hr-b0-77.ucode.ko /boot/kernel/iwlwifi-Qu-c0-jf-b0-77.ucode.ko /boot/kernel/iwlwifi-QuZ-a0-hr-b0-77.ucode.ko /boot/kernel/iwlwifi-QuZ-a0-jf-b0-77.ucode.ko /boot/kernel/iwlwifi-cc-a0-77.ucode.ko /boot/kernel/iwlwifi-so-a0-gf-a0-83.ucode.ko /boot/kernel/iwlwifi-so-a0-gf-a0.pnvm.ko /boot/kernel/iwlwifi-so-a0-gf4-a0-83.ucode.ko /boot/kernel/iwlwifi-so-a0-gf4-a0.pnvm.ko /boot/kernel/iwlwifi-so-a0-hr-b0-81.ucode.ko /boot/kernel/iwlwifi-so-a0-jf-b0-77.ucode.ko /boot/kernel/iwlwifi-ty-a0-gf-a0-83.ucode.ko /boot/kernel/iwlwifi-ty-a0-gf-a0.pnvm.ko /boot/kernel/rtw8723d_fw.bin.ko /boot/kernel/rtw8821c_fw.bin.ko /boot/kernel/rtw8822b_fw.bin.ko /boot/kernel/rtw8822c_fw.bin.ko /boot/kernel/rtw8822c_wow_fw.bin.ko all match this pattern and are skipped. I'm busy rewriting a bunch of kldxref to be a cross tool using libelf, but I think here you want to probably revert this and just add pkgsave to the list of "known bad" suffixes. -- John Baldwin