From nobody Thu Sep 25 16:57:56 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cXfzS63Tqz68J1t; Thu, 25 Sep 2025 16:57:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cXfzS4wXWz3jXL; Thu, 25 Sep 2025 16:57:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758819476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5Qp5ZNZrxVbX/0xJMtPRJuIqCqxqJe/DD15UAIzRYjw=; b=ZOIPYc5qi4ZXvuQx/F+ypv9hIxzIaPsiUs6L4nxeGsxsVdOc20DVoyuWQVRhTT5ZEk9oFG tIyZwo01OoLMKPdT5CBUFQBwh9sjXDDQERxbEe5bMLLtXyUcBEj9OqHeCEtrS1BWRmLO1W dGO4tSziOi0exOte7YsmOpP4k4cK+amcJPZ5BcF/Wx2FbQGQ9TYcVL6y7AKzsgbeezVLug 9h+l9ipyDHIyjKhVowQgm14QL9BGRSta1NNsoqMyJ0+95g6+ryhDSgaPUfTWacZfBiiuU3 pSuLod+AguuLcO0Bb8XHU5NQxtcPjq9jNvLAhvV4bhuaSci8J13/ul7CnMeWTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758819476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5Qp5ZNZrxVbX/0xJMtPRJuIqCqxqJe/DD15UAIzRYjw=; b=cvdXBjABBPePpqUVNWzGtMY2W9VP2piThLDEGghu1BMlw6o7Y8XpHxvueZiE6EgOgrXbbI BGDDw+ce4vLUZEV40tZKqgwbK0nbEEsVG5nwA5uzjMVm48PfhJkk8MsrvkMq42aEmJcBWu Dv9C3VHN9XwKtLyVtIzXBXlYCfB9g6Mcu2VzwB6apM3JWZFLr498mtJbzZ0WwhMQFhlBxJ 7MrnAhtiK13GknApzO90TbqZ7emZxnQLc2c5dhsHxuoWqzmkx6KBY2G1FCPEbrP26PTUfh D1g0conZBC5RssumlNRViVjOIBFywBvBoftDurWrno7yojUODAbIaRPcvPcXyg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758819476; a=rsa-sha256; cv=none; b=yai9m1F/Ztj+J7pALYVHuBAKNTpcNdkwd7nddq/cNOLDgpJeJ89kR4RvJiNJiVZ9MWBWp/ XfI+X8JxsZ8Ueyd92dSTvUgo40Nl2sw9ABwKvJQFfe23ZX+OJ2H2XpW1IL2h/nqGfVfNEy gWe3PSoVRsNiMPiOps49v15Si+kFpM0hNZXHLlJnnBQthri5lXy2sf/9UYsei85tS3yFzA SBt6UY3MEO28UBQrM0chRVZTuBpv89USBF70AatZw1EiICRUINnxDt42ITKE19ttOP+qO4 I6/NOxDrtG+llLbEgD+K20WPTWdzt/SemYFkyUBqh4GVL+++AaEDZBq5hfsuXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cXfzS4Qhwz1PXC; Thu, 25 Sep 2025 16:57:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58PGvuIv079558; Thu, 25 Sep 2025 16:57:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58PGvujh079555; Thu, 25 Sep 2025 16:57:56 GMT (envelope-from git) Date: Thu, 25 Sep 2025 16:57:56 GMT Message-Id: <202509251657.58PGvujh079555@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: e05521121f05 - main - ng_tty: copy to the correct mbuf List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e05521121f05a1b1e0d7c7b5fbe79f83fc303cd0 Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=e05521121f05a1b1e0d7c7b5fbe79f83fc303cd0 commit e05521121f05a1b1e0d7c7b5fbe79f83fc303cd0 Author: Ahmad Khalifa AuthorDate: 2025-09-25 16:54:28 +0000 Commit: Ahmad Khalifa CommitDate: 2025-09-25 16:55:28 +0000 ng_tty: copy to the correct mbuf memcpy should copy to the current mbuf, otherwise we're copying to the first mbuf in the chain over and over. Reported by: kevans Reviewed by: glebius MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D52713 --- sys/netgraph/ng_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index c7d8a1b64eac..0e3230a66f66 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -427,7 +427,7 @@ ngt_rint_bypass(struct tty *tp, const void *buf, size_t len) for (mb = m; mb != NULL; mb = mb->m_next) { length = min(M_TRAILINGSPACE(mb), len - total); - memcpy(mtod(m, char *), (const char *)buf + total, length); + memcpy(mtod(mb, char *), (const char *)buf + total, length); mb->m_len = length; total += length; m->m_pkthdr.len += length;