From owner-svn-src-all@FreeBSD.ORG Fri Sep 4 10:32:16 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 53C5D106566B; Fri, 4 Sep 2009 10:32:16 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id B6E2C8FC13; Fri, 4 Sep 2009 10:32:15 +0000 (UTC) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 98C141CE49; Fri, 4 Sep 2009 12:32:14 +0200 (CEST) Date: Fri, 4 Sep 2009 12:32:14 +0200 From: Ed Schouten To: "Andrey A. Chernov" Message-ID: <20090904103214.GW2829@hoeg.nl> References: <200909040742.n847gD62058267@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="S2CovAv8lqFB/Tem" Content-Disposition: inline In-Reply-To: <200909040742.n847gD62058267@svn.freebsd.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r196818 - head/contrib/ee X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Sep 2009 10:32:16 -0000 --S2CovAv8lqFB/Tem Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Andrey, * Andrey A. Chernov wrote: > 1) Remove single occurance of HAS_CTYPE ifdef, ctype functions > used here for a long time and needs their header in anycase. > 2) Add (unsigned char) casts to more ctype macros. > 3) Simplify menu input handling using ctype instead of range unguarded > hardcoded tricks. Even though I really appreciate fixes/cleanups to ee(1), I think changes like these should be sent to its maintainer as well. Have you done this? --=20 Ed Schouten WWW: http://80386.nl/ --S2CovAv8lqFB/Tem Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkqg7K4ACgkQ52SDGA2eCwXM2QCePT8DwLBxvB05e0nTuK1//1+g PRwAn1yb9FC4hPRQ8Or8PWJL8dSzRbHW =BNFE -----END PGP SIGNATURE----- --S2CovAv8lqFB/Tem--